Filtering subscriptions form has issues and needs improvement
| Project: | Notifications |
| Version: | 6.x-2.0 |
| Component: | User interface |
| Category: | task |
| Priority: | critical |
| Assigned: | Jose Reyero |
| Status: | closed |
Jump to:
On the user/uid/notifications/subscriptions page, there is a mechanism to filter subscriptions by various criteria. One of these is 'type'. On my site, only 'Thread' is enabled (in terms of modules and in terms of what's allowed for various pieces of content), yet it displays the options to filter by types 'Content type', 'Author' and 'Content type and author' as well. It would be great if these weren't displayed here, since this functionality doesn't exist on the site. Perhaps one could check if the user has any subscriptions of those types before deciding what to include? Or if they are enabled at all on the site?
Also, I have only one send method, and I think it would be great if the drop-down for method did not exist when there's only one method.
If the will isn't there for these options to exist in general, in what file should I modify things to take care of this on my site?
#1
Another thing that's on the same page:
If I filter by some criterion, then navigate away from the page, and then come back to the page later, then the old filtering I applied is still in force, yet the filter fieldset is collapsed so it doesn't indicate that any filtering has taken place. I think this is very confusing behaviour. Either the filtering shouldn't apply any more when the page is refreshed, or the fieldset should be shown fully to indicate that filtering is going on.
This functionality offered by this module is great, by the way --- keep up the good work.
#2
Bumping priority, to be fixed soon.
Please post all your issues with that form here so we can address all of them at once.
#3
my filter list has 2 "Threads" http://screencast.com/t/dSUHOlKNCc6X the first one filters to nothing, the 2nd one works.
#4
Done:
- Permission & status checking for sending methods and subscription types.
- Not showing filter when there's only one option.
- Show filter not collapsed when a filter is enabled.
About keeping filter status on session, that will stay the same for consistency with other drupal filters (like node admin)
Hope you guys like it. Thanks for the feedback.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.