When importing a Views 1 view, the Filefield display format is not preserved. Patch to follow.

CommentFileSizeAuthor
#4 filefield.views_convert.inc-455344-4.patch3.35 KBdarren oh
#2 filefield.views_convert.inc-455344-2.patch3.44 KBdarren oh
#1 filefield.views_convert.inc-455344-1.patch1.53 KBdarren oh

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Needs review
StatusFileSize
new filefield.views_convert.inc-455344-1.patch1.53 KB

Patch attached.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Format not preserved in views import » Conversion from Views 1
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new filefield.views_convert.inc-455344-2.patch3.44 KB

Added filter and argument conversion. I've tested this, and since there haven't been any others interested in testing, I'm marking it as ready to be committed.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Needs review

Hey Darren Oh, I'm planning on getting this in, I just haven't had time to review this yet. Do you know of any problems with the code (since this version is notably longer than the first version).

This definitely seems unnecessary:

+          foreach ($content_field['columns'] as $column => $attributes) {
+
+          }

I still haven't applied to test it out, since it requires a bit of set up.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
StatusFileSize
new filefield.views_convert.inc-455344-4.patch3.35 KB

This version is longer because it fixes all problems, not just one. There are no remaining issues that I know of. The unnecessary lines are removed in the attached patch.

quicksketch’s picture

quicksketch
he/him
commented
Category: bug » feature
Status: Needs review » Fixed

Thanks Darren Oh! Any implementation is better than none, so I've committed your patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.