Conversion from Views 1

Darren Oh - May 6, 2009 - 15:12
Project:FileField
Version:6.x-3.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

When importing a Views 1 view, the Filefield display format is not preserved. Patch to follow.

#1

Darren Oh - May 6, 2009 - 15:14
Status:active» needs review

Patch attached.

AttachmentSize
filefield.views_convert.inc-455344-1.patch 1.53 KB

#2

Darren Oh - May 19, 2009 - 15:51
Title:Format not preserved in views import» Conversion from Views 1
Status:needs review» reviewed & tested by the community

Added filter and argument conversion. I've tested this, and since there haven't been any others interested in testing, I'm marking it as ready to be committed.

AttachmentSize
filefield.views_convert.inc-455344-2.patch 3.44 KB

#3

quicksketch - May 19, 2009 - 16:18
Status:reviewed & tested by the community» needs review

Hey Darren Oh, I'm planning on getting this in, I just haven't had time to review this yet. Do you know of any problems with the code (since this version is notably longer than the first version).

This definitely seems unnecessary:

+          foreach ($content_field['columns'] as $column => $attributes) {
+
+          }

I still haven't applied to test it out, since it requires a bit of set up.

#4

Darren Oh - May 19, 2009 - 16:25

This version is longer because it fixes all problems, not just one. There are no remaining issues that I know of. The unnecessary lines are removed in the attached patch.

AttachmentSize
filefield.views_convert.inc-455344-4.patch 3.35 KB

#5

quicksketch - July 3, 2009 - 22:14
Category:bug report» feature request
Status:needs review» fixed

Thanks Darren Oh! Any implementation is better than none, so I've committed your patch. Thanks!

#6

System Message - July 17, 2009 - 22:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.