Duplicate view name causes module_invoke_all('views_default_views') error due to recursion

+1
I have had similar situations arise when two developers on my team accidentally set up a view with the same name. That makes for a fun day of debugging ..

ahh this issue got lost due to being marked needs work. Marking it needs review so that it'll show up in my patch queue.

I have relloled this patch against Views 3.x following the Coding Standards and made the patch using cvs diff -up to make easy the review.

+++ includes/cache.inc	10 Dec 2009 03:39:37 -0000
@@ -110,12 +110,22 @@ function _views_discover_default_views()
+                watchdog('view', "View name '$name' is already taken", array(), WATCHDOG_ERROR);

Watchdog uses

    return t($dblog->message, unserialize($dblog->variables));

to be able to translate the output, so a dynamic parameter like $name could fill the locale database.

I'm on crack. Are you, too?

Committed to all branches.

remove tag

This feature changed the way how views are imported.
After implementing this patch, some of my views disappeared.
It happen, because this code calling hook_views_default_views TWICE!

      $defaults = module_invoke_all('views_default_views');
...
      foreach(module_implements('views_default_views') as $module) {

Following code doesn't work after this patch:

/**
 * Implementation of hook_views_default_views()
 */
function hook_views_default_views() {
    $views = array();
    $path = drupal_get_path('module', 'my_module') . '/views';
    $files = drupal_system_listing('.inc$', $path, 'name', 0);
    foreach ($files as $file) {
        include_once "$file->filename";
    }
    return $views;
}

I know that's maybe not the right way to import views, but the fact is that it broke some Views on the server after Views upgrade.

Given relevant discussion here I'm reopening this instead of creating a new issue.

1) Patch in #8 adds new but does not remove old call to hook_views_default_views, which makes every *_views_default_views() called twice (see line $default = module_invoke... at the top of the patch)

2) Code in #12 should be '"include" instead of "include_once" to be repeatable

Same problem as #12 happens in advanced_forum #687196: Fatal Error with core-overrides

Since patch in #8 is committed to all branches, the fix is a one liner.

Patch attached. Tested.

I think i wrote a patch alreay, but this patch looks fine, too.

This patch only appears to apply to the 2.x branch, and is not needed for 3.x -- someone please confirm that for me. In the meantime, committed to 2.x

kenorb: While your use of include_once did help us discover a bug (perhaps we need tests here) it also should be highlighted that there are valid cases where default views will be loaded twice in a single page load -- in particular, during testing -- so you should use include and not include_once to ensure your views are always included.

yeah this is not needed for 3.x