When converting image fields to file fields, the format of views image fields is lost because the formatter names have changed. Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | imagefield.install-455368-7.patch | 2 KB | darren oh |
| #6 | imagefield.install-455368-6.patch | 1.26 KB | darren oh |
| #2 | imagefield.install-455368-2.patch | 1.54 KB | darren oh |
| #1 | imagefield.install-455368-1.patch | 1.56 KB | darren oh |
Comments
Comment #1
darren ohPatch attached. This may also be a problem with the field display formats, but the patch does not address this.
Comment #2
darren ohContent type field display formats are already converted correctly. Attached is an updated patch that can handle field names that start with the name of another field.
Comment #3
quicksketchI don't think this patch is necessary, since the name of the formatters didn't change because of the different field type, the name of the formatters was changed earlier. The imagefield_update_6004() already moves over the formatters when the name was changed.
Comment #4
darren ohThe formatters for content type fields are converted correctly. However, the formatters need to be converted for views as well. I discovered the problem when upgrading from Drupal 5 to Drupal 6 and Views 1 to Views 2. Those who upgraded some time ago have probably fixed their views already.
Comment #5
quicksketchAhh, I see. We should make a new update function rather than editing the existing one so that users who have already upgraded can get their views fixed.
Comment #6
darren ohOK. Added separate update.
Comment #7
darren ohFound some error notices when settings were left at defaults. Added fix to update.
Comment #8
quicksketchNot exactly a timely update, but I've committed the patch in #7 and it will be included in the 3.3 version of ImageField. Thanks Darren Oh!
Comment #9
quicksketchHm, well after all that I had to roll back the Views update because of the issues described in #785198: SQL error while updating with new DEV version. The default values portion of this update remains, but I feel that the Views upgrade path may never be fully corrected.