When converting image fields to file fields, the format of views image fields is lost because the formatter names have changed. Patch to follow.

Comments

darren oh’s picture

Status: Active » Needs review
StatusFileSize
new1.56 KB

Patch attached. This may also be a problem with the field display formats, but the patch does not address this.

darren oh’s picture

StatusFileSize
new1.54 KB

Content type field display formats are already converted correctly. Attached is an updated patch that can handle field names that start with the name of another field.

quicksketch’s picture

I don't think this patch is necessary, since the name of the formatters didn't change because of the different field type, the name of the formatters was changed earlier. The imagefield_update_6004() already moves over the formatters when the name was changed.

darren oh’s picture

The formatters for content type fields are converted correctly. However, the formatters need to be converted for views as well. I discovered the problem when upgrading from Drupal 5 to Drupal 6 and Views 1 to Views 2. Those who upgraded some time ago have probably fixed their views already.

quicksketch’s picture

Status: Needs review » Needs work

Ahh, I see. We should make a new update function rather than editing the existing one so that users who have already upgraded can get their views fixed.

darren oh’s picture

Status: Needs work » Needs review
StatusFileSize
new1.26 KB

OK. Added separate update.

darren oh’s picture

StatusFileSize
new2 KB

Found some error notices when settings were left at defaults. Added fix to update.

quicksketch’s picture

Version: 6.x-3.x-dev » 6.x-3.2
Status: Needs review » Fixed

Not exactly a timely update, but I've committed the patch in #7 and it will be included in the 3.3 version of ImageField. Thanks Darren Oh!

quicksketch’s picture

Hm, well after all that I had to roll back the Views update because of the issues described in #785198: SQL error while updating with new DEV version. The default values portion of this update remains, but I feel that the Views upgrade path may never be fully corrected.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.