Hi,
I got an error while creating a new release for the currency module, just when I submitted the add release form. Well, not exactly an error, but the release node has been created without notes, and it seems to be broken or something. As I cannot edit the node because the fields major/minor are empty.
This is the release node: http://drupal.org/node/455350
These are the release notes I wanted to use:
Changes since 6.x-1.0:
<ul>
<li><a href="http://drupal.org/node/270929">#270929</a> Converting from a currency to the same currency produces wrong results.</li>
<li>Chinese translation updated for Drupal 6.x release.</li>
<li><a href="http://drupal.org/node/329052">#329052</a> by markus_petrux, add decimal point count and a theme function for displaying amounts.</li>
</ul>
Comments
Comment #1
merlinofchaos commentedI've updated the node, but I have a feeling that won't be enough. So far as I know a tarball is only rolled when the node is generated. It may be necessary to delete this node and re-create it in order to get the version to actually roll. I guess we'll know for sure in a few minutes.
Comment #2
merlinofchaos commentedI was right and wrong at the same time:
Comment #3
dwwI'll look into this... please, no one take any drastic action yet. ;)
Comment #4
markus_petrux commentedThank you both for looking into this. The release node has now been published, but it doesn't contain version information and it looks weird in the project page:
http://drupal.org/node/455350
http://drupal.org/project/currency
Not sure how this will affect update status et al. :(
Comment #5
markus_petrux commented@Derek: maybe I could simply create a new tag and new release?
I'm concerned about the fact that Currency API is used by a lot of sites, and the project is now advertising a stable release that's broken.
Khalid gave me access to the project just to pack this release. :(
http://drupal.org/node/329052#comment-1559182
Comment #6
dww@markus: Today has been insane on d.o. OSLOSU network outage, fixing Solr badness, deploying more changes on d.o, etc. Please be patient. No one is paying me to maintain this site, so I can't guarantee any specific turn-around time for support requests like this.
Comment #7
merlinofchaos commentedIs the release broken? It has a tarball attached to it now.
Comment #8
kbahey commentedWould it help if I just unpublish this and and tag a 1.2 version in a new release ?
Comment #9
merlinofchaos commentedAhh, I see what you mean. The tarball has wrong version ID and it shows up blank on the project page. Annoying.
You'll just have to be patient, dww is having a long day.
Comment #10
markus_petrux commented@Derek: Ok, thanks for the feedback. It's much appreciated.
I also deal with a big site (11 servers, 2M p/v a day) and it sometimes happen odd things. Wish you best of luck! :)
Comment #11
dww@kbahey: Thanks, but no, that wouldn't help...
Comment #12
markus_petrux commentedFYI: I have updated the failed release with a note pointing to this support request.
http://drupal.org/node/455350
Comment #13
markus_petrux commentedOh, after I edited the release node, the tarball has been rebuilt! :-D
Comment #14
dwwWhat happened was the {project_release_nodes}.version field was set to an empty string for some reason, not "6.x-1.1". That's why the tarball had a bizarre name, and why it was looking so weird in the download table on the project page. My only theory is yet more badness with {cache_form} living in memcache and getting cleared when it shouldn't. We had all kinds of problems with corrupted release nodes right after upgrading d.o to D6 due to {cache_form}. Maybe there are edge cases where having that table in memcache at all is still causing problems. Maybe we can convince the memcache folks to special-case that table and always store it in the DB or something.
Anyway, I was hoping to try to carefully understand how this went wrong, but I'm obviously way too busy for that these days. :( So, I just repaired the release and regenerated the tarball. All should be well.
Comment #15
markus_petrux commentedAll I can say is I followed the same process to create this release node as I did on other projects. The only difference I see is Khalid gave me access to the project just to pack this release, and I believe I was quick in trying it out, maybe quicker than some kind of cached data was updated?
Anyway, thanks for fixing the tarball. I was concerned for the user base of the currency module, when my wish was to just encourage a release of a new addition to the Currency API that the Money CCK field module was in need to.
Sorry if I did anything wrong. :-/
Comment #16
dwwSorry if my comment implied you did anything wrong. Besides screwing up something in CVS (which is a lot harder to prevent, but clearly wasn't the problem here), the release node forms should never let you do anything wrong...