Jump to:
| Project: | Bibliography Module |
| Version: | 6.x-1.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
My project makes heavy use of multiple taxonomies to categorize biblio nodes instead of using biblio keywords. As a result, we want to be able to filter by multiple terms (e.g. Japan AND Culture), which causes an error in the original incarnation of biblio.pages.inc. Furthermore, I discovered that the way the query to retrieve filtered items was built was causing problems if I chose a type first and then tried to refine the selection using a taxonomy term. Basically, the order of parameters was getting out of sync with placeholders in the query string. Lastly, the display of the filter parameters ("Filters: type is Film and Taxonomy Term is Japan") was inconsistent in capitalizing the filter category (in the example here, "type" is not capitalized, while "Taxonomy Term" is).
A morning's testing seems to indicate that my modifications in the attached patch solve these issues.
| Attachment | Size |
|---|---|
| biblio_pages_alter_filter.patch | 3.9 KB |
Comments
#1
Looks fine to me, although I didn't see where "the order of parameters was getting out of sync with placeholders in the query string" was being addressed.
I've committed it with a few minor changes.
Ron.
#2
Hi, Ron:
Around line 340, the text for the WHERE contribution for the 'type' element was being placed in a string called $limit instead of added to the $where[] array. As a result, any 'type' parameters were being placed in a static location when the query string was built instead of being placed in order when the $where[] array was shifted.
By the way, thanks for all the hard work on getting such a complex module together...
#3
Automatically closed -- issue fixed for 2 weeks with no activity.