I noticed that if the extlink JavaScript code is run on a page more than once, all external links receive multiple icons. In my case, this is happening when I use a pager provided by a view that loads content using ajax--an icon is added every time that I use the pager.
I suggest modifying the JavaScript code in such a way that it ensures that only one icon is added per link, either by searching for the presence of a previously added icon, or maybe by simply checking the link for the "ext" class.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | extlink_class_check.patch | 824 bytes | quicksketch |
Comments
Comment #1
quicksketchThat's strange that the view page is causing the extlink icons to be doubled up, as Extlink should only find links within the new content loaded on the page. However, it'd be good to prevent this doubling-up even if it isn't extlink's fault. This patch should prevent these icons from ever being doubled up. If you can test it out I'd appreciate it.
Comment #2
dboulet commentedThanks quicksketch, I'll test the patch and get back to you tomorrow. I think that in my case the doubling is happening because I have multiple views embedded on the same page--I'm guessing that the JavaScript is being re-run on all of them.
Comment #3
dboulet commentedPatch works great, tested with Firefox, Opera, Chrome, Safari, IE7, IE6 on WinXP and Firefox, Safari on Mac OSX.
One question: should we be worried about people who add an "ext" class to their links in their markup? These links wouldn't get an icon.
Comment #4
quicksketchI committed this patch, thanks for testing!
We probably shouldn't affect these links, especially since modules like External Links Filter (http://drupal.org/project/elf) also use the "ext" link class and adds its own styling. Of course if you've installed that module and this one, you'd probably have problems anyway.