Rework admin/user/settings

Anything that cleans that page up...

Nice work, works great.

tagging. Screenshots look good, didn't look at patch yet.

Looking good but a 'before' page would still be helpful.

Oooh, look there it is: http://img.skitch.com/20090507-nnm1at43ure82iw4ifd8dys7my.jpg

I'm delegating this patch to catch. I will commit it when catch thinks it is ready. (@catch, if you don't want to champion this patch, let us know please.)

Semi-related: #432962: Add option to disable password strength checking

All looks good except signatures is now lumped in with user account cancellation. I think we should try to keep it grouped with user pictures if possible (not sure what the fieldset for that should be called though). I kept thinking the checkbox was a setting related to the radios, which of course it isn't.

Agree with catch. Extra mess when enabling user pics is not an argument, it's actually pretty nice these only show up after choosing to enable them. So yes, group signatures with user pictures, put it above user pictures and all the extra form fields (screenshot of those) for user pics will not break anything. Then rename the cancellation fieldset to "account cancellation".

Then group cancellation with signup options, makes sense to group the options for 'in' and 'out', no?

____ Registration & cancellation ___    <- not pretty, but let's not focus too much on copy writing in this issue

Registration
…
Account cancellation
…
____________________________________


____ Personalisation _______________

Signatures
…
User pictures
…
____________________________________

That looks good, but yeah it needs a title.

Good looking changes. Since catch marked #460296: Clean up user settings form duplicate of this one, I am hereby requesting to roll in the Anonymous username setting to this new page. This patch makes the page look much better then my patch did, with a lot more changes obviously.

Also, while I like "Who can register accounts?", I don't like how it shows up with the colon. Drupal usually does not use this question / answer format anyway.

Looks good visually. Just tagging to help me keep track of this.

I think this is good use of the vertical tabs (unlike some of the other patches that I've seen) -- like catch et al, I do think it needs a title. Maybe just put it in a fieldset?

I also noticed that some options end with a point, whereas others don't.

I'd consider renaming 'Enable signatures' to 'Enable signatures for authenticated users'.

Similarly, I'd rename 'Enable pictures' to 'Enable pictures for authenticated users'.

The '?:' in 'Who can register accounts?:' is a bit odd but I'm not sure how to solve that elegantly.

Xano: I think that since you grouped the anonymous username with the authenticated personalization options, it looks more like we support personalization for anonymous (which we do support to some degree via anonymous contact details in comment module, but not here).

I had exactly the same worry as Gabor in #22.

Xano: well, I suggested grouping it with the registration setting in my original issue. That seemed logical, since it showed a logical progress from anonymous user to user registration. You already have registration grouped with cancellation. I think it would make sense to put the initial anonymous username there too. That is important for how non-authenticated user posts look before they register and after their account is cancelled (in some cases).

Putting it right up top above registration works for me too - anonymous - registration - cancellation, nice easy progression.

I have been told that coding standards say to use U.S. English spelling, so 'personalisation' needs to be changed to 'personalization'.

That still leaves the "Who can register accounts?:" issue - which is a very old issue I don't think we should try to fix here. I'd lean towards putting the patch in with that bug exposed, and then try to finally get it fixed before release.
#67211: Show colon after form title only when there is no other punctuation

Xano - could you post another screenshot?

Can I see more screenshots of the vertical tabs?

I read through the patch and I think this looks fine. Pretty sure the vertical tabs haven't changed since the last screenshot, so RTBC.

@Bojhan: why do you need more screenshots? A couple of screenshots are included above.

Patch works as intended. Very big improvements IMHO! Attached is a full page screenshot and here's a few more screenshots of the vertical tabs:

Password recovery should be last, you have two groups Welcome and Acount - password recovery looks a bit placed in between these. However shouldn't hold this patch up, I asked for screenshots of Vertical tabs because in the origin patch of this ui pattern I saw some trouble (visually) with slim titles combined with long content area - in this patch it looks fine though.

Here's a patch with the vertical tab change mentioned above: password recovery weight I set to 100 which throws it to the bottom of the list. Looks good /methinks

Don't know if 100 is the good approach, not any objections from me.

I think we should move 'User settings' from 'Users' to 'Site configuration'. We can do that in another patch.

I think we should remove the trailing dot from most options -- we don't add dots to other options in core, except maybe when they are truly sentences.

Instead of 100, let's use 10.

A few more things.

RCS file: /cvs/drupal/drupal/modules/taxonomy/taxonomy.test,v

I am pretty sure this patch has nothing to do with taxonomy.test. ;)

-    '#title' => t('Account cancellation settings'),
+    '#title' => t('Registration and cancellation')

Please leave the comma at the end here, per coding standards.

+      t('Administrators only.'),
+      t('Visitors.'),
+      t('Visitors, but administrator approval is required.'),

No dots. Dries already said that.

+  // If picture support is enabled, check whether the picture directory exists:

exists. Period, not colon.

Having a look at this patch - I like the changes, however I personally (and I know - just one voice that is not offering code...) do not like the idea of having a fieldset for anonymous users with just one option in there - could it also be merged with "Registration and cancellation" as was proposed by Gabor in #460296: Clean up user settings form?

I also liked how there was a description for the user pictures and the signatures next to their check boxes.

cross posted.

Ok, here's a reroll against HEAD.

- keeps the ',' at the end of the #title change
- removes the periods from t() options
- period, not colon in comment
- weight of password recovery set to 10

Now that's sexy.

Committed to HEAD. Thanks for all the hard work, folks!

Please also see followup with #645738: UX: Vertical-tabify the rest of the admin/config/people/accounts page.