use of t() in coder.drush.inc line 10 should be replaced with dt()

rsvelko - May 6, 2009 - 22:01
Project:Coder
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

with t() I get an undef func error in drush....

go on the 10th line and change that please. Tested that dt() works.

dt() is the drush equiv of t().

This is the same with coder 6.1 and 6.2 - maybe with 5 too.

#1

dereine - May 9, 2009 - 20:30
Status:active» needs review

i had the same issue

here is a small patch

AttachmentSize
coder-drush-t-to-dt.patch 1 KB

#2

rsvelko - May 14, 2009 - 19:42

come on :) easy one :)

#3

dereine - May 14, 2009 - 20:20

thats true :)

perhaps you could test the patch at set it to reviewed by the community :)

#4

pobster - May 14, 2009 - 22:14
Status:needs review» reviewed & tested by the community

This doesn't need testing - it's a no-brainer...

Pobster

#5

gnat - May 15, 2009 - 14:59

+1 on the patch. Worked great for me.

#6

stella - May 15, 2009 - 15:27
Status:reviewed & tested by the community» fixed

Fixed in 6.x-1.x-dev, 6.x-2.x-dev and 7.x, along with another t() function that was missed. Thanks for the patch!

#7

John Morahan - May 18, 2009 - 11:40
Version:6.x-2.x-dev» 5.x-2.x-dev
Status:fixed» needs review

Hi, any chance you could apply it to 5.x too please?

AttachmentSize
coder-drush-t-to-dt.patch 1.35 KB

#8

stella - May 19, 2009 - 20:12
Status:needs review» fixed

Fixed in 5.x dev version

#9

System Message - June 2, 2009 - 20:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

joachim - July 27, 2009 - 19:35

Any chance of a new release so this fix is included?
The mere presence of the module -- even disabled -- breaks drush :(

#11

AdrianB - August 24, 2009 - 01:16

I couldn't imagine that the mere *presence* of the module, as joachim mentions, could break drush. So I spent hours and hours trying to get drush working and looking in all the wrong places.

Since the fix is so simple once the source of the error is found I would really encourage a new release of Coder.

If a new release is not possible for some other reason, then at least update the project page with a warning that Coder 6.x-1.0 breaks drush just by being in the modules directory. Then hours of debugging would be saved for others...

#12

anarcat - August 24, 2009 - 23:58
Version:5.x-2.x-dev» 6.x-2.x-dev
Priority:normal» critical
Status:closed» active

Reopening this issue: it's clearly breaking drush and while it is fixed in CVS, no release has been done for at least a year now and this is impeding all drush work on sites that actually use it.

Please release.

#13

drupaloo - August 25, 2009 - 02:55

Double that on re-opening this issue.

Drush crashes due to this error on my sites.

Please fix asap and release a new rc rev.

#14

dereine - August 25, 2009 - 04:51
Status:active» fixed

apply the patch and be happy.

Coder is definitive not a critcal of your website, so you sure can use a dev-version/apply the patch/replace the t() calls with dt()

#15

AdrianB - August 25, 2009 - 08:35

apply the patch and be happy.

Coder is definitive not a critcal of your website, so you sure can use a dev-version/apply the patch/replace the t() calls with dt()

Why so hostile instead of helpful?

It's not critical, but it's a bug that been known for a long time and it causes a lot of headaches and lost hours because it breaks Drush by it's mere presence and that is difficult to troubleshoot if you don't know where to look.

Why NOT release an update? It's a known bug and it has a known fix.

I asked moshe weitzman of Drush to warn people about this, but he says it's the responsibility of the coder team:

please ask the coder team to issue a new release. it has been a year.

So Drush won't warn people about it, and Coder won't fix the bug... there will be more lost hours I guess as Drush get more and more attention...

#16

anarcat - August 25, 2009 - 19:01

It has been a year... I volunteer for releasing a new version on 6.x by the end of september if no one else does.

#17

drupaloo - August 26, 2009 - 01:21

@ dereine:

I agree with AdrianB - Why so hostile?

I do not know how to create or apply a patch. I am a novice. I am using coder to learn how to develop good code.

Thank you anarcat for tentatively volunteering a fix - I would volunteer but I dont know how to code enough yet.

#18

drupaloo - August 26, 2009 - 00:29
Status:fixed» active

#19

dereine - August 26, 2009 - 06:56

I do not know how to create or apply a patch.

Then you can use the dev versioon.

#20

stella - August 27, 2009 - 20:51
Status:active» fixed

A new version of coder will be released once the D6 to D7 reviews are more stable, probably end of September. However, this issue is fixed in the dev version, so re-setting the status.

#21

AdrianB - August 28, 2009 - 07:47

Then you can use the dev versioon.

I don't think you understand what I've been trying to say. If you come this far then this is a non issue. The fix is easy. But we're trying to help other people from have to go through the same problems to find this out.

The problem is not the that the dev version works, the problem is knowing that the dev version works.

The problem is that this bug causes an error in Drush which is very hard to troubleshoot if you don't know where to look. Most people prefere the stable release over a dev version, so that's what they download.

Then they download Drush and can't make it work and they have no idea why. Now, Drush could do a better job when handling errors and warn that the mere presence of a module with a small bug can break Drush. But Drush don't and therefor the user has no idea what's causing the error.

#22

stella - August 28, 2009 - 10:00

Another release, on the 6.x-2.x branch, will be made in the coming weeks, once the D6 to D7 reviews are finished.

#23

drupaloo - August 28, 2009 - 11:03

@ dereine:

AdrianB in post 21 has done an excellent job at trying to explain to you the issues facing someone who wants to use the module but does not understand enough about coding, dev versions, etc.

Drupal makes it very clear that dev versions should not be used on production sites.

So I do not use dev versions.

So you telling me to use the dev version is of no help.

#24

dereine - August 28, 2009 - 11:56

Are you really using coder on production sites?

Does any of your users see coder module?

Additional modules can have bug fixes in the dev version.

#25

AdrianB - August 29, 2009 - 23:55

@stella: Great!

@dereine:

No, I don't use coder on a production site, but that's not the issue. (Coder breaks Drush even if it's not enabled or ever were.)

The issue here is that this particular bug breaks drush and you have no idea that coder is the culprit. It's quite natural to assume that only the enabled modules breaks things, so you'll start looking in all the wrong places. We're trying to save frustration and time for others.

I do use dev versions if they contain bug fixes, but like most others I start by using the released version first, and if that fails me I'll try the dev version. But the problem here, and I feel like I'm repeating myself a lot now, is that you don't know that Coder is the module that needs the dev version. Drush could implement a special warning about this, but they won't because this issue has been known for a year now and the fix should be committed, like moshe weitzman said.

#26

rsvelko - August 31, 2009 - 13:58

plus it is a 2 letters' patch ... no brainer.

#27

stella - August 31, 2009 - 16:36

The patch has been committed already, see comments #6 and #8. Please use the dev version until an official version is ready.

Stella

#28

System Message - September 14, 2009 - 16:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#29

alexanderpas - September 21, 2009 - 17:20

drush dl coder = breakage!!! <- it shoudn't!!!
drush dl coder-6.x-1.0-dev = fix.

can we get drush dl coder working again please!?

#30

drew reece - September 27, 2009 - 14:28

Add me to the list of people frustrated by this!

I got the drush error, searched for the fix and found another thread that didn't resolve it.

Wasted a couple of hours until I found this patch.

Please release the fix, it's been 5 months and the advice is still 'apply the patch' or 'use a dev release'. If it is broken it should be fixed.

 
 

Drupal is a registered trademark of Dries Buytaert.