I have all the latest modules, latest php, etc. The module is working.

However, I don't need the email confirmation feature (nor does the link sent in the email work)

Is there a way to disable this through code?

CommentFileSizeAuthor
#3 publicbookings.456406.patch3.97 KBAnonymous (not verified)
#3 publicbookings.FIX-PATCH.patch1.35 KBAnonymous (not verified)
#2 publicbookings.456406.patch2.62 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Postponed (maintainer needs more info)

Hmm ... can you copy the text of the mail? Is there anything in the logs? Which version of Drupal and Bookings API are you using?

I'll write a patch to disable Email confirmation tomorrow :)

Anonymous’s picture

Anonymous (not verified) commented
Title: remove email confirmation requirement » Optionally remove email confirmation requirement
Assigned: Unassigned »
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new publicbookings.456406.patch2.62 KB

Do NOT apply this patch.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new publicbookings.FIX-PATCH.patch1.35 KB
new publicbookings.456406.patch3.97 KB

This patch adds a new setting "Whether to require email-verification for new (public) bookings - Highly Recommanded."
If this setting is checked, nothing will change - if this is unchecked, no confirmation email is required any more. New bookings will be treated as if the confirmation link was already visited.

--

My apologies - I attached the wrong patch above. Please use the one attached here.
If you already applied the patch above, the second one fixes the problems.

Apply the first of the patches attached to this post. ONLY apply the second patch (publicbookings.FIX-PATCH.patch), if you already applied the patch of the post above!

ballerjones’s picture

ballerjones commented

Thanks a million. I'm not sure how to apply a patch, but I will figure it out.

Anonymous’s picture

Anonymous (not verified) commented

Start by having a look at http://drupal.org/patch/apply . Another explanation is at at http://drupal.org/node/34422#comment-75030 :)

ballerjones’s picture

ballerjones commented

I patched it and it worked. However, I'd like each booking to need approval. As it is now, upon booking, the reservation is finalized without the need of administrator approval. Also, is there a way to send an email to an arbitrary address when a reservation request is made?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Read and placed on "to do"-list :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Please see #463530: bookingsapi_record_status_change ignores booking-status - with this patch bookings will require approval.

Anonymous’s picture

Anonymous (not verified) commented
Category: support » feature

Changed category. Regarding the email-notification I've opened a new issue (#463534).

edit: Please also see #463536: Emails send have wrong title/content (corrects subject and body of confirmation mails)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

I have committed the above patches into cvs. Please update to latest bookingsapi and publicbookings dev-releases, as soon as they are release. Feel free to reopen if any problems occur.

ballerjones’s picture

ballerjones commented

you're the best, tirsales - i hope you don't mind me taking advantage of your prompt effectiveness, but I wonder if you know what the problem is here:

http://drupal.org/node/462732

I'll understand if you don't have the time

thanks again

ballerjones’s picture

ballerjones commented

I figured out why the confirmation link wasn't working in the first place. The link assumes mod_rewrite and clean URL's are enabled. Consider having the code either notice this automatically or placing an option in the settings page.

Otherwise, it works well. I can't find a way to edit what is said in the emails though.

Anonymous’s picture

Anonymous (not verified) commented

Thanks, I will rewrite the code doing the mailing accordingly.

The text of the email is not configurable at the moment, but I will add a patch to allow this.

--edit Please see issues #468166: Email-Notification assumes that clean URLs can be used and #468168: Text of the email-confirmations should be configurable.

ballerjones’s picture

ballerjones commented

As long as you are here, is there a way to specify a role/user that gets an email after any booking is requested? This way, any user with role "bookingsmanager(for example)" would receive an email notifying them of a new booking being made and a link to the administration screen. This would be an extremely useful addition to your already very useful module.

Thanks

Anonymous’s picture

Anonymous (not verified) commented

At the moment there is only the possibility to add a single mail-address that gets notified on updates. The patch is available here: #463534: Strange Log after creation of a new booking. There is currently no real notification handling, but I am planning to integrate one.

Please open a new issue for new feature requests / bugs - I really am thankful for your help and feedback, but separating issues makes live easier ;)

ballerjones’s picture

ballerjones commented

Sorry about that, I'm just not very familiar with this support system.

I think I'll just use that patch you linked to, but I've also posted a feature request: http://drupal.org/node/468720

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.