As we agreed to do, I am opening a different task report for xmlsitemap_node.module.
The removed code is the code for the bulk operation, and for changing the sitemap priority of a node basing on the comments it received.
Also here, the idea is to put the code in a different module that would make explicit its dependency from comment.module, which would avoid to add all those IF-statements to check if the module is really enabled.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | xmlsitemap_node_install_096590.patch | 3.35 KB | avpaderno |
| #7 | xmlsitemap_node_093333.patch | 1.95 KB | avpaderno |
| #3 | xmlsitemap_node_091123.patch | 8 KB | avpaderno |
| xmlsitemap_node.module.txt | 10.99 KB | avpaderno |
Comments
Comment #1
Anonymous (not verified) commentedComment #2
Anonymous (not verified) commentedWe need a patch file for this one.
Comment #3
avpadernoComment #4
avpadernoThe comment eater bug is still around. I wrote that I previously forgot to add the patch I already prepared.
Comment #5
Anonymous (not verified) commentedI'm happy with it.
Comment #6
avpadernoThe changes have been committed; now it's time for the not anymore used table fields.
Comment #7
avpadernoThis is the change for the module code.
Comment #8
avpadernoThis is the patch for the installation file.
Comment #9
avpadernoI was forgetting: also the description that the module passes in a custom hook should be changed.
Comment #10
avpadernoComment #11
Anonymous (not verified) commentedVisual inspection looks good. Does anyone have a method to test the upgrade paths?
Comment #12
avpadernoIf you change the data for the module in the system table, and set the field containing the last update done to -1, and then visit update.php, would that make the kind of test you mean?
Comment #13
Anonymous (not verified) commentedThat would test 6.x-1.x-dev to 6.x-1.x-dev upgrade path and whether or not anything fails because an action has already completed. I'm more interested in 5.x-1.6 to 6.x-1.0-BETA1 upgrading.
It will be several hours into days before I can get back to this.
Comment #14
avpadernoIf you tell me how to test it, I will do it. I can install Drupal 5 on my test site, and follow the procedure you suggest.
Comment #15
avpadernoThe problem of testing the update path is not specific for this changes, but to the general update code; we can commit the changes, and only after find a way to test the update from 5.x-1.6 to 6.x-1.
Comment #16
avpadernoThe changes have been committed in CVS.
Comment #18
avpadernoComment #19
Anonymous (not verified) commentedComment #20
dave reidIf we haven't gotten to this yet, I doubt we'll ever get to it. Marking as won't fix.