Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When I attempted to install the XML sitemap menu module I was hit with a number of DB errors.
I accidentally erased the error itself but it is fully reproducible and I even have a quick and easy solution :-)
To reproduce:
uninstall the "Core - optional" Menu module.
try to install xml sitemap menu module.
Big blaring errors :-)
To fix:
add the Menu module to the list of dependencies for xml sitemap menu
Comments
Comment #1
avpadernoEffectively, the module doesn't declare the dependency from menu.module; therefore, Drupal allows you to enable xmlsitemap_menu.module even if the Drupal core module is not enabled.
I don't know why, but I took that menu.module was not optional.
Nice catch.
Comment #2
avpadernoI changed the code in CVS, and fixed the problem.
I hope it's ok if I already did it, as all I had to do was to add
dependencies[] = menuin xmlsitemap_menu.info; since the change doesn't involve code, I thought I could apply the change directly.Thanks for the report.
Comment #3
avpadernoI just noticed that the same problem could happen to another module.
I will investigate on this.
Comment #4
avpadernoIt happened with xmlsitemap_taxonomy that didn't declare its dependency from taxonomy.module, even if it is using functions of that module.
I also changed the declaration of dependency from xmlsitemap_node.module into the one from xmlsitemap.module.
As collateral effect, I removed the declaration of dependency of xmlsitemap_term.module that is now an empy shell. The files will be removed later.
Comment #5
Anonymous (not verified) commentedSarcastic remarks require sarcastic answers. ;p