This is the similar task for xmlsitemap_taxonomy.module.

The code doesn't show the changes required for xmlsitemap_taxonomy.install.

CommentFileSizeAuthor
#7 xmlsitemap_taxonomy_093489.diff7.55 KBavpaderno
xmlsitemap_taxonomy.module.txt7.18 KBavpaderno

Comments

Anonymous’s picture

Anonymous (not verified) commented

I don't understand what you're trying to say?

Anonymous’s picture

Anonymous (not verified) commented
Title: Removal of not strictly necessary features » Streamline xmlsitemap_taxonomy module code
Status: Active » Postponed

Patches, not the entire file please.

cvs diff -up > xmlsitemap_taxonomy.patch

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Streamline xmlsitemap_taxonomy module code » Removal of not strictly necessary features
Status: Postponed » Active

I mean that, if the removed code was using a Drupal variable, the update function should remove that variable. The code I reported is only the one for the module.

Anonymous’s picture

Anonymous (not verified) commented
Title: Removal of not strictly necessary features » Remove unnecessary features from xmlsitemap_taxonomy
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I need to check how to change the parameters used from the editor; right now it uses diff -u.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Yeah, using -p is super helpful since it is easier to tell what function(s) the patch changes are in.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new xmlsitemap_taxonomy_093489.diff7.55 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Reviewed & tested by the community

I'm happy with this one as well.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

I committed the changes in CVS.
In this case, there aren't any table fields that need to be removed, but there is something to review. I didn't actually remove the hook_nodeapi() because without it, the data about a taxonomy term would not updated.
IMO, as the page listing the nodes tagged with the same taxonomy terms changes when a new node is tagged with a new term, the taxonomy links should have their changed timestamp updated as well.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

In absence of reviews, I set this report as fixed; feel free to reopen it if you think also hook_nodeapi() should removed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Closed (fixed) » Active
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Postponed
Issue tags: +release 6.x-1.1
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Postponed » Closed (won't fix)

If we haven't gotten to this yet, I doubt we'll ever get to it. Marking as won't fix.