As 2CO payment method has it's own completion routine, GA code isn't showing on 2CO's completion page. I made a patch, which resolves this bug in simpliest manner.

CommentFileSizeAuthor
#4 uc_2checkout_GA_fix_new.patch508 bytesneochief
#3 uc_2checkout_GA_fix_hook.patch803 bytesneochief
uc_2checkout_GA_fix.patch559 bytesneochief

Comments

rszrama’s picture

rszrama commented

This hack shouldn't be necessary. That's why the hook_ucga_display() was introduced:

/**
 * Implementation of hook_ucga_display().
 */
function uc_2checkout_ucga_display() {
  // Tell UC Google Analytics to display the e-commerce JS on the custom
  // order completion page for this module.
  if (arg(0) == 'cart' && arg(1) == '2checkout' && arg(2) == 'complete') {
    return TRUE;
  }
}

Do users end up at /complete or /finalize?

neochief’s picture

neochief commented

Ah, yes, I didn't noticed that it's a hook.

neochief’s picture

neochief commented
StatusFileSize
new uc_2checkout_GA_fix_hook.patch803 bytes

Here's a patch for this.

neochief’s picture

neochief commented
StatusFileSize
new uc_2checkout_GA_fix_new.patch508 bytes

Heh, missed existing hook. Here's a new patch.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Committed.

neochief’s picture

neochief commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.