I have a user/register form that contains some extra required fields, e.g. full name, terms and conditions checkbox, and so on. I've encountered an issue with a form error and mollom validation. The steps to reproduce are:

  • User goes to user/register and doesn't enter in a value for all the required fields
  • User enters captcha correctly and submits
  • the expected error about the missing field appears
  • user enters the missing value, and correctly fills in new captcha
  • user submits the form, but gets the error "The entered CAPTCHA solution is not correct. We generated a new CAPTCHA so please try again."
  • This error keeps repeating no matter how many times the user enters the captcha correctly

I think it's something to do with the session id associated with the 1st captcha is different from the subsequent ones. The attached patch fixes the issue, though there may be a better solution.

Cheers,
Stella

CommentFileSizeAuthor
mollom_session.patch1.69 KBstella

Comments

robschmitt’s picture

robschmitt commented

I can confirm that this bug is present is 5.x-1.8 as well. Stella's patch works, so thanks very much for that.

Allthegearnoidea’s picture

Allthegearnoidea commented

As beforeseven points out this problem is in 5.x-1.8 too. I've also applied stella's patch and it's fixed the problem and so far I haven't found it causing any other issues.

The patch seems to be marked as ignored. Is there some way to make it more official so the problem gets permanently fixed in the next version of Mollom?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

This patch looks correct to me.

1) $GLOBALS['mollom_captcha'] seems to be unused throughout the module, probably a mistaken variable name.

2) Yes, we should send a session_id for mollom.getImageCaptcha. Interestingly, the module already sends one in mollom_ajax_callback(), but that is only used for switching CAPTCHA types.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

I agree that this patch looks good. I committed it to DRUPAL-5 so it will be part of the next release of the Mollom module. Thanks for your patience.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.