Hi,

From my testing, it seems that unlimited_css.module doesn't work with conditional_styles.module.

I have a theme that optionally uses conditional_styles.module to insert a conditional IE stylesheet (but you can use Zen.theme as a test theme for this).

When I have both modules enabled, this stylesheet doesn't appear in the rendered HTML source. When I have one of these modules enabled, the stylesheet does appear.

Not sure where the responsiblity lies, but I'll let you decide whether to pass this onto the conditional_styles.module maintainer.

Thanks.

CommentFileSizeAuthor
#3 unlimited_css-457124-3.patch734 bytesAnonymous (not verified)

Comments

bengtan’s picture

bengtan commented
Title: Does not work with conditional styles » Unlimited css loader does not work with conditional styles
Anonymous’s picture

Anonymous (not verified) commented

I can confirm this bug.

I'll have a read through the code to try and work out what's wrong and see if I can create a patch for it...

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new unlimited_css-457124-3.patch734 bytes

Here you go. A rudimentary patch that simply adds the value of $vars['conditional_styles'] to the $styles variable.
Ideally you'd create a separate <style> element, surrounded by conditional comments, that @imports the various IE-specific stylesheets. But I don't see how this would be possible with the current setup...

Also, I'd recommend removing the restriction of only having 15 imports per <style> as someone may have lots of conditional stylesheets which could breach the limit of 30. Not likely, but possible...

ademarco’s picture

ademarco commented

Thanks for the patch BWPanda, I'll review it during the next days...

ademarco’s picture

ademarco commented
Status: Needs review » Fixed

Patch applied. Thanks for patching.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.