Add "more" link to new "Recent issues" block

stella - May 8, 2009 - 08:37
Project:Project issue tracking
Version:6.x-1.x-dev
Component:Views integration
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active
Description

First of all, great work with the new changes to the project pages. I really like the new blocks. However, I would like to see a new "see all" or "more" link added to the bottom of the new "Recent issues" block on the project page. Currently the only way to see all the project's issues is to click on the 'Advanced Search' link in the "Issues" block, which isn't totally intuitive.

Cheers,
Stella

#1

kiamlaluno - May 11, 2009 - 14:01
Title:Add "see all" link to new "Recent issues" block» Add "more" link to new "Recent issues" block

The link is normally named more.

#2

kiamlaluno - May 11, 2009 - 15:12

Actually, it is possible to see all the issue reports by clicking on the number of issue reports that is under All issues, in the Issues for <project> block that is exactly over the block you are watching.

#3

dww - May 11, 2009 - 20:59
Project:Drupal.org webmasters» Project issue tracking
Version:<none>» 6.x-1.x-dev
Component:Other» Views integration

I'm not opposed. The only problems are that:

A) There's already links to "more" in the "Issues for X" block (as Kiam points out). But, I guess it doesn't hurt to provide additional ways to find the issue queue page.

B) When I tried this on my laptop when I was first working on the block, the "more" link would point to project/issues/[nid] (e.g. http://drupal.org/project/issues/3060) not project/issues/[name] (http://drupal.org/project/issues/drupal). I'm not exactly sure why that is, and maybe there's an easy work-around in views for this.

#4

dww - May 11, 2009 - 21:07

Here's an example of 3.B:

http://d6.drupal.org/project/drupal

I asked merlinofchaos about this, and yeah, there's no particularly elegant way to deal with this. The problem is that the argument validation + transformation code only goes one way -- the project short name ("drupal") is converted into the project nid (3060) via the argument validator, but there's no way to map that back to the short name when the block is trying to create the right link to the page view based on the argument. The block gets the argument from the (implicit) nid in the URL when you're viewing a project page. But, it doesn't have any good way to convert that into the more human-readable URL we normally use for the issue queues. http://drupal.org/project/issues/3060 does in fact work, it's just ugly.

About the only way to hack-around this is via a theme template for the block that re-writes the more link on the fly. Kinda yucky.

Not sure it's worth worrying about this too much, but I wish there was a better solution.

#5

kiamlaluno - May 11, 2009 - 23:59

As a side note, using http://drupal.org/project/issues/3060, and http://drupal.org/project/issues/drupal would cause the search engines to report that some pages have duplicate titles. It's not something to worry about too much, but if it would avoided when possible.

#6

dww - May 12, 2009 - 05:59

@Kiam: Yes, I'm aware. The problem is that for ages, d.o supported both styles, and there's going to be too much linkrot if I force everything to the name-based views. I don't know of any way in views to automatically redirect numeric arguments to the corresponding string argument. That's completely equivalent to the problem I explained in #4. Plus, for example in this case, it's even worse since the integer is what we actually need for the queries, so internally, views is seeing a project node ID in all cases, even if you use a project short name in the URL.

/me shrugs.

 
 

Drupal is a registered trademark of Dries Buytaert.