The sass_api_settings form would be a lot more straight forward if it used system_settings_form. The many items of sass_api_vars array are all derived from two user submitted values.

Sass files would be specific to each theme, and a Drupal site can have many themes running at once. All of them might have Sass stylesheets. However, this module only supports a single theme. If two themes are active simultaneously, the Sass settings for the admin form's theme will overwrite the other theme settings. I think these values should be stored in the theme_settings array for each theme (and thus edited on each theme's admin page) or each sass_input value should be stored in a different theme-key specific system variable.

All the munging and fussing with the sass_input value could happen at run time. If the other values need to be changeable, they should be in the admin form.

Comments

nighthwk1’s picture

I ran into this bug when I tried using the module for the first time... I had a different theme set for the admin area, and was wondering why it kept telling me it couldn't find the .sass file I added. Turns out it was looking in my admin theme folder, and not my main theme. Unfortunately, this module is useless for me until this bug is resolved.