When there are multiple themes enabled on a site, the 'Theme configuration' fieldset in the user's account edit page displays the enabled themes' .info file names and paths rather than the actual theme names and descriptions contained in the .info files.

I've attached a patch to fix this but I've never rolled or submitted a patch before so I apologize if it needs tweaking.

CommentFileSizeAuthor
#2 Picture 2.png48.24 KBakahn
#1 system_theme_select_form_new.patch1.05 KBjames marks
system_theme_select_form.patch1.05 KBjames marks

Comments

james marks’s picture

james marks commented
Status: Active » Needs review
StatusFileSize
new system_theme_select_form_new.patch1.05 KB

Resubmitting the patch and changing the status of the issue. (Ran the patch change in the wrong direction the first time.)

In the system.module file in the system_theme_select function, the patch specifically changes this:
#title' => $info->name, '#markup' => dirname($info->filename)

to this:
#title' => $info->info['name'], '#markup' => $info->info['description']

to correctly display the theme name and description.

akahn’s picture

akahn commented
StatusFileSize
new Picture 2.png48.24 KB

I like this patch and it seems to work fairly well. But look what happens when one of the themes has a long description (see attached image). It makes a very wide page.

I think the text needs to wrap and should probably have similar styling (or at least markup) to admin/build/theme. But I'm not sure that is within the scope of this issue.

james marks’s picture

james marks commented

I didn't address the issue of the text wrapping because I felt, also, that it wasn't in the scope of this particular issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work

Well. I think the purpose of this issue is to make the table here match a lot more closely the table under admin/build/themes. And that means we should add some table wrapping here like that table has as well.

Also, subscribe.

james marks’s picture

james marks commented

Understood. I'll get on that. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Incidentally, it might be possible for us to just re-use the same theme function here. If so, that'd be ideal because they'll stay in sync in the future.

heine’s picture

heine commented

Tableless, recolorable, multi-column, fluid width theme.

Say what?

This theme demonstrates Drupal's default HTML markup and CSS styles. To learn how to build your own theme and override Drupal's default code, you should start reading the Theming guide.

Huh?

The audience of the admin/build/themes table is very different from the audience on the user edit page. For the average site user, the info description is about as useful as the paths.

james marks’s picture

james marks commented
Status: Needs work » Closed (fixed)

This issue appears to have been resolved in both D7 and D6 without the use of this patch. Closing the issue.