Just a minor thing. From the documentation and module description it looks like this module works with "4.6 or later". Just tested it out with 4.7 (CVS) and it seems to be incompatible.

CommentFileSizeAuthor
#2 disknode_0.JPG33.75 KBKieg Khan

Comments

elmuerte’s picture

Component: Documentation » Code
Assigned: Unassigned » elmuerte
Category: bug » feature
Priority: Minor » Normal

Ok, thank for the report. As soon as time frees up I will set up a drupal 4.7 test environment.
I'll update the documentation for now.

(changed to feature request for 4.7 compatibility)

Kieg Khan’s picture

Version: master » 4.7.x-1.x-dev
Category: feature » support
StatusFileSize
new33.75 KB

Is anyone looking at this module? What sort of time lag should I accept before starting to make a lot of noise? This issue was flagged in January and the download is still on the 4.7 distribution page, but is clearly not ready for 4.7 release. Can it be removed?

I am not a programmer, but I have run the disknode.module through the Form Updater.module to see what errors are flagged and whether this fixes anything. I have also posted my results to the form updated area for explaination of the following code:-

Drupal 4.6:
 form($form2, 'POST'); 

Drupal 4.7:
 $form['#method'] = 'POST';
$output = drupal_get_form('your_form_id', $form); 
Replace your_form_id with an appropriate id.

Originally I got an error when I installed DiskNode when trying to access admin->settings->disknode, the error was undefined function form_textarea (or similiar). See the screen shot, after running the code through form updater I do not get the error, but the input area for the file location is also missing and when I goto /node/add/disknode, nothing happens.

I suspect this is because the 'your_form_id' entry does not have the right value. I do not know what this value should be, or even what it should look like, so any suggestion or help would be great.

I think this is probably an easy module to fix, so hopefully with a few heads on the job we can get it going.
Thanks.

elmuerte’s picture

Yes, the current 4.7 tar can be removed. In fact I never wanted it there.

Anyway, I've been very busy the last couple of weeks and hardly had any time looking at the 4.7 port of this module

elmuerte’s picture

Status: Active » Fixed

Ok, had enough time to fix various things. It should now work with 4.7, or at least I didn't get any errors so far.

Kieg Khan’s picture

Hello,
I have downloaded the file from the modules area but it still gives the same errors as previously. If you have an updated 4.7 module can you please post the file here or explain to me how I can get the latest version?

I am happy to provide feedback and testing if I can get the updated module.
Thanks.

elmuerte’s picture

Doh, forgot to tag the code so it would be packed as a 4.7 module.
This CVS branching stuff to create releases is somewhat annoying.

Anyway, the 4.7 download should be updated shortly (I think).

Kieg Khan’s picture

Thanks elmuerte,

This works really well now. I have one question, how do I delete the physical file from the server? Currently in the Disknode manager I can browse the files, I can upload the files and I can replace an existing file, but there does not seem to be any way to delete the file.

This might be a Drupal issue, but when I delete the document the associated files are not deleted either. My server is Windows 2003 running IIS, so maybe it is not an issue under Linux/Apache.

Would it be possible to add a delete option to the disknode file manager? Or is it possible to delete files now but I am doing something wrong?

Thanks for your excellent response. Contributions such as yours is what has impressed me most about Drupal over other systems I have assessed.

elmuerte’s picture

It's currently not possible to:
- delete
- rename
- move
files or directories

These features are planned (in the "file info" page). DiskNode has a lose connection between a node and file, therefor deleting a node has no effect on the file. For this reason it's possible to have multiple nodes link to the same file (although each link will have it's own entry and therefor it's own download counter).

Anonymous’s picture

Status: Fixed » Closed (fixed)