Posted by neochief on May 9, 2009 at 6:38pm
| Project: | Ubercart |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | ubercamp sprint |
Issue Summary
I found a pretty weird style attribute at 2CO's review table, which brings the review buttons float over the rest of the table. This can't be avoided, as style hardcoded into table tag. I replaced it with a class, so if someone acually need this, he could add these styles to his theme.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| uc_2checkout_weird_style_fix.patch | 535 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Can you post a screenshot? This is the same bit of styling we use for the PayPal WPS form and it doesn't seem to cause any troubles. : ?
#2
Yes, sure. Take a look at the in_garland.png first. As you may see, the weird code ballanced by inside table's margins, which included into garland theme.
But if your theme has no such margins (especialy top one (and you really have them removed, if you want your margins work everywhere)), the table itself became a line (as it is display:inline), so couple of buttons are alligning in a such way that shown in buggy_in_own_theme.png. And the real problem is that you can't do anything to fix it, because this styles are hardcoded into the table.
In other hand, if you remove this styles, everything will still looks great (see in_garland_fixed.png)
#3
#4
If the current inline styles are the ones that seem to work in Garland and some other themes, those should probably be set as the default styles for the new class as well, which can be overridden now in the theme if in a case such as yours, they need to be.
Also, only dashes should be used in css classes/IDs, so 2checkout_review_table should be 2checkout-review-table
#5
My text editor didn't seem to like a class that started with a number, and an id seemed more appropriate to me in this case, so I called it
#two-checkout-review-table.#6
Don't have a place to test this, but code changes look good!
#7
Good enough for me. Thanks, steph.
Committed.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.