The function check if the table exists, before to count the number of links present in it; it would be useful if it would write a log message in that case.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | xmlsitemap_092397.patch | 1.48 KB | avpaderno |
| #5 | xmlsitemap_092396.patch | 1009 bytes | avpaderno |
| #1 | xmlsitemap_092395.patch | 715 bytes | avpaderno |
Comments
Comment #1
avpadernoComment #2
avpadernoThis has been changed in CVS.
Comment #3
Anonymous (not verified) commentedI don't agree with the message. The reason the table doesn't exist is due to the fact that the hook_menu implementation of xmlsitemap.module uses the function and hook_menu is called before the table exists. The only time the table doesn't exist is on a fresh install which isn't an error.
Comment #4
avpadernoThat is not true; the table could not exist for many other reasons, including the fact the table has been accidentally dropped. A fresh install must have the table installed, otherwise an error occurred during the installation of the module.
The message can be shorted to The xmlsitemap table has not been found; in this way, the message would not implicate anything wrong happened with the installation of the modules.
There are many other functions that could report a message in the Drupal log; I am changing the report title to reflect the extended task.
Comment #5
avpadernoThis is the patch that changes the previously added call to
watchdog(); it also simplify the code by assigning a default to the static variable, which allows the IF-statement to be changed fromto
.
Comment #6
avpadernoThis is the complete patch for xmlsitemap.module.
Comment #7
avpadernoxmlsitemap_092397.patch has been applied, and the changes committed in CVS. The final code is a little different from that because it has been slightly optimized.
xmlsitemap_delete_cache_files()is now defined asComment #8
Anonymous (not verified) commentedI'm considering to mark this as won't fix. We don't need to SPAM the watchdog table.
Comment #9
dave reidAgreed with won't fix. This is unnecessary.
Comment #10
Anonymous (not verified) commented