Download & Extend
ImageCache Actions » Issues

Text filtering should be module user's duty

Posted by crea on May 10, 2009 at 9:42pm
Project:ImageCache Actions
Version:5.x-3.1
Component:Text Actions Module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

We shouldn't check_plain() text returned by php code because

  1. We are not printing it in browser
  2. encoded HTML entities are ugly when put on images :)

Patch is simple
textactions.inc, line 240:

-- $text = check_plain($text);

This probably applies to 6.x too

Login or register to post comments

Comments

#1

Posted by crea on May 10, 2009 at 11:13pm

This probably applies to static text action too.

#2

Posted by dman on May 11, 2009 at 12:07am
Version:5.x-3.x-dev» 5.x-3.1

Thanks. It's a fair fix.
I put that into 5--3 and did a release while I was there (it had been pending for a while, waiting for the imageapi incompatability to settle down)
http://drupal.org/node/458984

Didn't look like static text had any problem with it.
Same fix also ported to the version 6 dev

#3

Posted by dman on May 11, 2009 at 12:07am
Status:needs review» fixed

#4

Posted by System Message on May 25, 2009 at 12:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.