Text filtering should be module user's duty
crea - May 10, 2009 - 21:42
| Project: | Imagecache Actions |
| Version: | 5.x-3.1 |
| Component: | Text Actions Module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
We shouldn't check_plain() text returned by php code because
- We are not printing it in browser
- encoded HTML entities are ugly when put on images :)
Patch is simple
textactions.inc, line 240:
-- $text = check_plain($text);This probably applies to 6.x too
#1
This probably applies to static text action too.
#2
Thanks. It's a fair fix.
I put that into 5--3 and did a release while I was there (it had been pending for a while, waiting for the imageapi incompatability to settle down)
http://drupal.org/node/458984
Didn't look like static text had any problem with it.
Same fix also ported to the version 6 dev
#3
#4
Automatically closed -- issue fixed for 2 weeks with no activity.