Hi Scott,

Wasn't sure how to get in touch with you since you are not accepting Drupal msgs. A client of mine was requesting a "send email about about this link" feature in a site that they have. I started looking at your tellafriend module and figured it was a good start; but had a couple short comings:

- it won't work with new 4.7 forms API
- it doesn't seem to include the link to the site in the email that gets sent; not sure if i am maybe missing the point then of the module or maybe i just missed something in the code???
- it doesn't use the generic mail wrapper (user_mail) - using the mail wrapper allows someone to set up their drupal site to use something like phpmailer class rather than php mail function - this allows someone to send mail using an authenticated SMTP server (which i needed to do).

Anyway - i have made all these changes and figured i could just send you the new code so that you could commit. I have a 4.6 and 4.7 version to "submit" so i guess iiwll need to send 2 of these "bug reports".

cheers,
Peter Lindstrom
druapl aka = ptalindstrom
pta@allanalog.com

=================== more info ===================

changes include:

- works with 4.7 (i.e. uses new forms API)

- added page URL into msg body; and shows this in the form to fill out
   -  add <strong>[link placeholder]</strong> into “Message Text” in tellafriend settings to put referring page URL into email body.

- pulled senders name from subject – not sure why you’d want it there; but can always put it back if it makes sense to you.

- switched to use mail wrapper rather than php mail function
   -  pretty sure this is how all modules should be since that way they can use phpmailer and use authenticated smtp servers
   -   not sure why this isn’t in Drupal by default – I had to get this working first since I needed it

You can check it out on my site at http://petersplace.allanalog.com (click mail icon in header)

PS – formatting of the email that gets sent could stand to be cleaned up a little. Just didn’t get to it.

CommentFileSizeAuthor
tellafriend.module8.06 KBliquidcms

Comments

thierry_gd’s picture

Status: Reviewed & tested by the community » Fixed

Modifications taken into account in drupal 5.x version

Anonymous’s picture

Status: Fixed » Closed (fixed)