Full text submenu not displayed when Panels 3 module activated
Laurent_ - May 11, 2009 - 09:02
| Project: | Submenu Tree |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Hi,
Full text submenu (with or without links) is not displayed when Panels 3 module is activated.
This is because Panels 3 requires Delegator modules. This module handles 'page_callback' as 'delegator_node_view' and not as 'node_page_view'.
This makes the test at line 346 of submenutree.module fail (if ($v['link']['hidden'] == false && $v['link']['page_callback'] == 'node_page_view') ...).
Proposed fix :
if ($v['link']['hidden'] == false &&
($v['link']['page_callback'] == 'node_page_view' || $v['link']['page_callback'] == 'delegator_node_view') )Thanks
Laurent
#1
Hi,
I have no idea what you guys are doing in Panels 3, but I'll take your word for it :)
I have committed a fix, but differently from yours:
if ($v['link']['hidden'] == false && in_array($v['link']['page_callback'], array('node_page_view', 'delegator_node_view'))) {Either your version or my version will work.
Now, do you need me to make an official release for this, or are you okay with patching your system and waiting indefinitely?
#2
Thanks bengtan
I'm fine with patching my system.
Laurent
#3
Automatically closed -- issue fixed for 2 weeks with no activity.