The url args you specify in the view tabs that is getting loaded via ajax of a parent QT block are not seen.

This patch just keeps track of the original url and sends it to the ajax qt render function to work around the problem.

CommentFileSizeAuthor
#8 patch_quicktabs.jpg65.33 KBbomarmonk
#1 quicktabs.2.patch1.59 KBsarvab
quicktabs.patch1002 bytessarvab

Comments

sarvab’s picture

sarvab commented
StatusFileSize
new quicktabs.2.patch1.59 KB

This is a repatch that fixes a similar problem of args like '%#' of a single QT block of multiple views not getting set properly in the Drupal.settings object on initial load. (since the other tabs do not pass through quicktabs_render)

sarvab’s picture

sarvab commented
Status: Active » Needs review
pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

can you write the steps how to reproduce the problem?

sarvab’s picture

sarvab commented

These are basically the steps I took:

1) Create an ajax QT block that has 3 views block both using arguments and a url reference in the arguments (%1)

2) Create another QT block exactly like the above with 3 different views

2) Create one more ajax QT block that has the above two QT blocks as its blocks

Since it only renders the first view (tab) of the first top level QT tab, all other views do not get their arguments sent to them properly.

bomarmonk’s picture

bomarmonk commented

Can you make a patch against the current development version, as I get the following error when trying this patch: "Fatal error: Call to undefined function quicktabs_load() in C:\mysite\includes\menu.inc on line 410." But I am experiencing odd behavior with arguments if I reorder my tabs. Not good!

bomarmonk’s picture

bomarmonk commented
Priority: Normal » Critical

Is this still a problem or has this been committed to CVS? I'm marking as critical, since any rearrangement of tabs receiving arguments creates broken tabs.

bomarmonk’s picture

bomarmonk commented

I can confirm that this problem still exists in the dev version.

bomarmonk’s picture

bomarmonk commented
StatusFileSize
new patch_quicktabs.jpg65.33 KB

Using the above patch on the development version (dated November 2009), I have the following problems. First, only part of the patch succeeds. Please see the attached screen shot for what fails.

Second I get the following error when trying to edit an existing quicktab:

Fatal error: Call to undefined function quicktabs_load() in C:\wamp\www\mysite.org\includes\menu.inc on line 410

Can someone who is familiar with the module get this patch working with the latest development version of quicktabs? I can confirm the problem exists and is a serious issue for anyone wanting to use arguments with quick tabs of various contextual views. In my case, I am displaying related nodes based on the taxonomy term of the currently viewed node. This works okay until I make the taxonomy based view second in order for my quicktabs-- then the view fails to display.

bomarmonk’s picture

bomarmonk commented
Priority: Critical » Normal

Correction: this is not critical, since the arguments work just fine without loading them with ajax. If you are using arguments with quicktabs, elect "load all at once" rather than using ajax to load the tabs separately. Hopefully both options will work with arguments in the future.

Todd Young’s picture

Todd Young commented

It would be really nice for this to work with AJAX, since sometimes the point of deferring tab loads is that the initial page takes way to long to load if all tabs have to be called up at once.

Does the patch above work and has it been merged into any new version as of yet?

netw3rker’s picture

netw3rker commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)