Add per role region visibility.

CommentFileSizeAuthor
#2 region_visibility-459926.patch3.03 KBpedrofaria

Comments

q0rban’s picture

q0rban commented
Version: 6.x-1.0-alpha1 » 6.x-1.x-dev
pedrofaria’s picture

pedrofaria commented
Assigned: Unassigned » pedrofaria
Status: Active » Needs review
Issue tags: +patch, +roles, +region, +region visibility
StatusFileSize
new region_visibility-459926.patch3.03 KB

I made this patch and work in my drupal installation.

Take a look and make some tests.

Enjoy!

I don't know how you are organizing your CVS repository, tell me more about it...

q0rban’s picture

q0rban commented
Status: Needs review » Needs work

Ok, this is a good start. Thanks for getting on this so quick! My suggestions, that I would appreciate your feedback on:

  • Add a serialize setting to the roles field in the db schema and in the update function, and then remove this: $region['roles'] = serialize(array_filter($region['roles']));
  • Get the preprocess_function function to actually check the roles, as it doesn't appear that's happening yet.
  • Change the update function number to 6101.

As far as CVS structure, all I have right now is 6.x-1.x branch. So work in that for any commits.

Thanks Pedro!

pedrofaria’s picture

pedrofaria commented

Sorry, i forgot to make it work.. lol

I really didnt know serialize db type... great

Ok, i will make all changes now!

cua

q0rban’s picture

q0rban commented

Pedro, I've committed a patch to dev, so make sure you update before making your changes.

q0rban’s picture

q0rban commented
Status: Needs work » Fixed

If you have time, please test what I've committed for this. Marking as fixed.

Status: Fixed » Closed (fixed)
Issue tags: -patch, -roles, -region, -region visibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +, +roles, +region, +region visibility

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.