Download & Extend
Javascript Aggregator » Issues

Switch to JSMin+

Posted by Rob Loach on May 12, 2009 at 2:35pm
Project:Javascript Aggregator
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

http://crisp.tweakblogs.net/blog/1665/a-new-javascript-minifier-jsmin+.html

Login or register to post comments

Comments

#1

Posted by derjochenmeyer on May 13, 2009 at 5:59am

Looks good, but what about this?

Note that we don't recommend using this tool for on-the-fly minification!

#2

Posted by Rob Loach on May 13, 2009 at 11:11am

JavaScript Aggregator caches the compressed files once they are processed so this shouldn't be a problem.

#3

Posted by derjochenmeyer on May 21, 2009 at 12:35am

@Rob Loach: Can we just add jsminplus.php to javascript_aggregator? Licence should be no problem?

Attached is a patch that introduces this idea by creating an option "Use JSMin+ instead of JSMin".

  1. copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
  2. apply patch to current 6.x-1.x-dev

JS size with JSMin: 24 KB
JS size with JSMin+: 22 KB

AttachmentSize
jsminplus.patch 1.73 KB

#4

Posted by derjochenmeyer on May 21, 2009 at 12:35am
Status:active» needs review

#5

Posted by derjochenmeyer on May 23, 2009 at 2:28pm

rerolling for current dev version.

  1. download and copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
  2. apply patch to current 6.x-1.x-dev
AttachmentSize
jsminplus_2009-05-23.patch 1.71 KB

#6

Posted by Rob Loach on May 23, 2009 at 2:56pm

Instead of adding it as an option, what are your thoughts on fully switching to it instead?

#7

Posted by derjochenmeyer on May 23, 2009 at 3:02pm

Sure, i introduced an option only because I wanted a quick way to swtich between the scripts on various test-sties.

Do you see any disadvantage in using an option for both? Maybe in some environments JSMin works while JSMin+ produces errors?

rerolling again for current dev version after (http://drupal.org/cvs?commit=215432).

1. download and copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
2. apply patch to current 6.x-1.x-dev

#8

Posted by derjochenmeyer on May 23, 2009 at 3:01pm

forgot the file... :)

AttachmentSize
jsminplus_2009-05-23_2.patch 1.95 KB

#9

Posted by morningtime on June 1, 2009 at 11:16am

I get an error message when using this patch with 6x1xdev:

"Parse error: Illegal token in file '[inline]' on line 985"

#10

Posted by Wim Leers on June 1, 2009 at 11:26pm

Report it to the developer. He's very eager to get his hands on files that can trigger problems. Also note that a newer version of JSMIN+ has been released.

#11

Posted by derjochenmeyer on July 22, 2009 at 9:47pm
Status:needs review» fixed

committed: http://drupal.org/cvs?commit=241454

New version 6.x-1.3 released.

#12

Posted by derjochenmeyer on July 22, 2009 at 10:10pm
Status:fixed» closed (fixed)

#13

Posted by ClearXS on June 26, 2010 at 6:44am
Status:closed (fixed)» needs work

there are several errors connected to this new feature; just search on "Parse error: Illegal token in file '[inline]' on line" ...

I'm not sure which module caused it together with activating JSMin+ (latest release in latest dev module) as I have many modules activated.

Others say EazyEdit (&FileField?) but I hadn't installed that module. Error disappeared on bringing JSMin+ back to JSMin

#14

Posted by derjochenmeyer on December 24, 2010 at 1:30am
Status:needs work» closed (fixed)

Please discuss if we should drop JSMin+ here: #940342: Javascript Aggregator: Allowed memory size ... exhausted