http://crisp.tweakblogs.net/blog/1665/a-new-javascript-minifier-jsmin+.html

CommentFileSizeAuthor
#8 jsminplus_2009-05-23_2.patch1.95 KBderjochenmeyer
#5 jsminplus_2009-05-23.patch1.71 KBderjochenmeyer
#3 jsminplus.patch1.73 KBderjochenmeyer

Comments

derjochenmeyer’s picture

derjochenmeyer commented

Looks good, but what about this?

Note that we don't recommend using this tool for on-the-fly minification!

robloach’s picture

robloach
he/him
commented

JavaScript Aggregator caches the compressed files once they are processed so this shouldn't be a problem.

derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new jsminplus.patch1.73 KB

@Rob Loach: Can we just add jsminplus.php to javascript_aggregator? Licence should be no problem?

Attached is a patch that introduces this idea by creating an option "Use JSMin+ instead of JSMin".

  1. copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
  2. apply patch to current 6.x-1.x-dev

JS size with JSMin: 24 KB
JS size with JSMin+: 22 KB

derjochenmeyer’s picture

derjochenmeyer commented
Status: Active » Needs review
derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new jsminplus_2009-05-23.patch1.71 KB

rerolling for current dev version.

  1. download and copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
  2. apply patch to current 6.x-1.x-dev
robloach’s picture

robloach
he/him
commented

Instead of adding it as an option, what are your thoughts on fully switching to it instead?

derjochenmeyer’s picture

derjochenmeyer commented

Sure, i introduced an option only because I wanted a quick way to swtich between the scripts on various test-sties.

Do you see any disadvantage in using an option for both? Maybe in some environments JSMin works while JSMin+ produces errors?

rerolling again for current dev version after (http://drupal.org/cvs?commit=215432).

1. download and copy jsminplus.php to the javascript_aggregator dir (download from http://files.tweakers.net/jsminplus/jsminplus.zip)
2. apply patch to current 6.x-1.x-dev

derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new jsminplus_2009-05-23_2.patch1.95 KB

forgot the file... :)

Anonymous’s picture

Anonymous (not verified) commented

I get an error message when using this patch with 6x1xdev:

"Parse error: Illegal token in file '[inline]' on line 985"

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Report it to the developer. He's very eager to get his hands on files that can trigger problems. Also note that a newer version of JSMIN+ has been released.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Fixed

committed: http://drupal.org/cvs?commit=241454

New version 6.x-1.3 released.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Fixed » Closed (fixed)
ClearXS’s picture

ClearXS commented
Status: Closed (fixed) » Needs work

there are several errors connected to this new feature; just search on "Parse error: Illegal token in file '[inline]' on line" ...

I'm not sure which module caused it together with activating JSMin+ (latest release in latest dev module) as I have many modules activated.

Others say EazyEdit (&FileField?) but I hadn't installed that module. Error disappeared on bringing JSMin+ back to JSMin

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Closed (fixed)

Please discuss if we should drop JSMin+ here: #940342: Javascript Aggregator: Allowed memory size ... exhausted