Update to Webpicasso PageEar v1.4 & Backport to 5.x

manfer - May 12, 2009 - 15:12
Project:PageEar
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:manfer
Status:closed
Description

This module is based on Webpicasso PageEar v1.2. I have updated the code to use Webpicasso PageEar v1.4 which should resolve some issues and has new features (sound on peel open, sound on peel close, posibility to add a close button...). I added those new features to the configuration form of the module and rearranged the form grouping similar features in fieldsets. Some fields with only two choices are changed from select to radio buttons.

I also backported the module to 5.x.

I don't know how to contribute. I have read some of the development documentation but I'm very new to this. No CVS experience for example.

Anyway, though I have read the CVS docs, I think it is the responsible of the project the one who has to accept the colaboration and give access to the CVS.

I don't know if I can do a patch file. I could read the doc if someone tells me that is possible. The changes to update the module involves the total replace of all files in pageear folder inside pageear module with the new v1.4 webpicasso pageear files, and new code in pageear.module file (this one is the file I could maybe do a patch for).

On the other hand, it is long ago since this module is not updated, is it still maintained?

I would apreciate any help to guide me through the process of contribute to this project.

Thanks.

#1

manfer - May 16, 2009 - 19:46
Category:task» support request

#2

Slanj - May 20, 2009 - 14:14

Hi! I am also interested in this question.
Can you post link to download backported the module to 5.x.

Thanx in advance!

#3

Slanj - May 20, 2009 - 14:19

You can attach your updated module in this thread for first time :) .

#4

manfer - May 21, 2009 - 09:49

This is for drupal 6.x version
--------------------------------

-- As an introduction --

The module pageear has this structure:

--------------------------------------------

- pageear
pageear.info
pageear.module
-- pageear
AC_OETags.js
copyright.txt
history.txt
index.html
pageear_b.jpg
pageear_b.swf
pageear_s.jpg
pageear_b.swf
pageear.js

--------------------------------------------

The inner pageear folder contains the files of Webpicasso pageear (AC_OETags.js, copyright.txt, history.txt, index.html, pageear_b.jpg, ...) and as you can see some of then are binary files: 2 jpg files, 2 swf files. It is not posible to make a patch of those files.

I'm not the maintainer of this project. I have no access to CVS (only anonymous access).

Now I know, more or less, how CVS works and I know how to make a patch. I can post the patch for the file pageear.module but the update would also require the replacement of the files in the inner pageear folder with files of v.1.4 of webpicasso pageear.

---------------------------------------------

The v.1.4 files of webpicasso pageear can be downloaded from: Webpicasso blog

You have to search on that page:
Pre Release v1.4:
29.06.08: PageEar v1.4 (PagePeel free) Download

What you download there is v.1.4 in a zip file. If you unzip that file you get a pageear folder. That is the folder that would be the replacement for the inner folder of the drupal pageear module.

(Note: With that change the actual version of pageear drupal module would still work though it would not use the new features).

---------------------------------------------

I attach the path needed for file pageear.module:
pageear_module.patch

If you made the replacement of inner folder and aply this patch you have drupal pageear module updated to use the new features.

---------------------------------------------

(Note: All this for 6.x module. For 5.x wait for another post)

AttachmentSize
pageear_module.patch 30.74 KB

#5

manfer - May 21, 2009 - 11:21

This is for drupal 5.x version
--------------------------------

-- As an introduction --

The module pageear has this structure:

--------------------------------------------

- pageear
  pageear.info
  pageear.module
  -- pageear
    AC_OETags.js
    copyright.txt
    history.txt
    index.html
    pageear_b.jpg
    pageear_b.swf
    pageear_s.jpg
    pageear_b.swf
    pageear.js

--------------------------------------------

The inner pageear folder contains the files of Webpicasso pageear (AC_OETags.js, copyright.txt, history.txt, index.html, pageear_b.jpg, ...) and as you can see some of then are binary files: 2 jpg files, 2 swf files. It is not posible to make a patch of those files.

I'm not the maintainer of this project. I have no access to CVS (only anonymous access).

Now I know, more or less, how CVS works and I know how to make a patch. I can post the patch that would apply to files pageear.info and pageear.module but the update would also require the replacement of the files in the inner pageear folder with files of v.1.4 of webpicasso pageear.

---------------------------------------------

The v.1.4 files of webpicasso pageear can be downloaded from: Webpicasso blog

You have to search on that page:
Pre Release v1.4:
29.06.08: PageEar v1.4 (PagePeel free) Download

What you download there is v.1.4 in a zip file. If you unzip that file you get a pageear folder. That is the folder that would be the replacement for the inner folder of the drupal pageear module.

---------------------------------------------

I attach the path needed that would apply changes to files pageear.info and pageear.module:
pageear_module_v5_x_dev.patch

If you have made the replacement of inner folder and aply this patch, you have a drupal pageear module for drupal 5.x and with the v.1.4 webpicasso pageear new features.

---------------------------------------------

If you don't know how to work with patches I provide a zip version of all the module just prepared for test. No need to patch, no need to replace inner folder. Just totally prepare to install as another module, unzip and copy it to your sites/all/modules folder.
pageear_module_v5_x_dev.zip

But this is only to test it is not a release. It is not in drupal CVS repositories.

Any feedback would be apreciated. If some people test, works fine and there is interest on it I will continue trying to contact the maintainer.

Thanks.

---------------------------------------------

AttachmentSize
pageear_module_v5_x_dev.patch 32.08 KB
pageear_module_v5_x_dev.zip 117.24 KB

#6

UnderDesign - May 27, 2009 - 09:18

Tried this on an old Drupal 5 website and it works fine and I'm definitely interested in using PageEar going forward with both 5.x and 6.x sites.

One thing; on 6.x, you can control where PageEar appears using the Condition module. How would you replicate the same functionality in 5.x?

Regards

Patrick

#7

manfer - June 15, 2009 - 23:20

I'm almost finish with my own pageear to make this module not dependant of any other modules than core ones and not dependant on a non GPL proyect.

- It would provide the posibility to have more than one pageear in a website (not more than one in same pages but in different pages).

- Visibility control would be in a block like way. You can control visibility based on page language for a multilanguage site, user role, and the pages you configure (even with PHP code if pageear administrator have the permissions to do so). If you are familiar with block visibility configuration you'll know what I mean.

- If more than one pageear is configured to display on same page only the first one would be visible.

Soon I would provided it for test and feedback. It would be for 6.x. It is just working by now and only TODO things are more work on flash (on peel shadows) and form validation (still have not code validation of number fields).

I would try to make a port to 5.x. If someone could point me to a 5.x module that use block like visibility I could study that code. Maybe is similar or exactly the same as in 6.x.

To answer UnderDesign question, the previous version 5.x I provided was only a port to make it work in 5.x but as conditions have not 5.x version it was not possible to control visibility with that module.

#8

manfer - June 17, 2009 - 23:23

I have finished 6.x

I'm working on 5.x now and almost done too. I would provide both versions to test and get feedback soon. If you think it is interesting I can by now ask for permission to maintain the module and provide the update (as a beta at first).

The only thing TODO after finish probably would be to adjust a little peel appearence (flash work). I'm still not totally satisfied with shadows.

And for future I would test if it works with png and gif files (I think on flash part it is just prepared to do). I don't see the need to restrict images to jpg files. Probably would be possible to allow even flash movies (swf), one 100x100 movie for the unpeel state and a 500x500 for the peel state but not sure if I'm going to achieve this.

#9

manfer - June 19, 2009 - 17:13

As for the work on shadows in flash mention before, I think I have all finished.

I provide both version 6.x and 5.x if someone wants to test and give me feedback.

-----------------------------
6.x version has both install and update features to be installed without errors in a drupal installation that never had a previous version of the module as well as one that had it in past.

For a clean install in a drupal installation that never had this module installed, the way to proceed is like with any other module. Upload files and enable module.

For an installation on a drupal site that has or had in past any version of pageear module. Disable previous version and remove files of previous version (if still installed). Upload new version files. Do an update.php (very important to generate database table needed in this version). Enable module.

NOTE: the update doesn't use your previous configure pageears in any way. If you need your old ads you have to get all images you need for previous version and configure pageears again. This version does not use conditions to manage pageears visibility. Visibility is now controlled within the module in a block visibility like way. So, take this in mind, no previous pageears would be present in this version. You would start from scratch.
-----------------------------

-----------------------------
5.x version does not provide update. It is supposed no one has a 5.x version of this module so the way to install is as a clean installation of a module. Upload files. Enable module.

If you need to test it in a drupal installation where you installed the previous 5.x version I provided for test. The way to proceed would be:

- If previous version still present: disable previous version, delete previous version files, upload new version files, go to Admin->modules->uninstall, select pageear an hit uninstall button, go to module list and enable module.

- If previous version is not present but had been installed before: upload new version files, go to Admin->modules->uninstall, select pageear and hit uninstall button, go to module list and enable module.

NOTE: As with version 6.x you would start from scratch with your pageears. Now in this 5.x version you can control visibility of pageears in a block visibility way. Is a version totally as functional as 6.x I provide (only I was still not able to port two buttons on configuration form to 5.x version but not esential at all. Everything you can do in this 6.x version you can do it too in 5.x version).
-----------------------------

I hope someone could test it and feedback please. Thanks in advance.

I attach files:
pageear_v5.x.zip contains the 5.x module version.
pageear_v6.x.zip contains the 6.x module version.

AttachmentSize
pageear_v5.x.zip 120.73 KB
pageear_v6.x.zip 127.55 KB

#10

big_ham - July 7, 2009 - 04:02

WOW. Incredible changes from the original. Bravo. This needs to go into the CVS ASAP. I'm using it for Drupal 6 and not only does it work where the original wouldn't ... it is HIGHLY configurable. Honestly ... KILLER.

#11

danreb - July 8, 2009 - 15:40
Category:support request» bug report

I just installed this on my site http://drupal.danreb.com and I noticed when I test it using IE 6 and 7 the big swf works fine and it's shows the reflection of the big image in the peel.

But when I used Firefox, Opera, Netscape and Safari browsers, the big swf does not show the reflection anymore and it just show the background colors.

I have all these browser installed on my system and able to test it on these browser.

I tried to adjust different configuration in the admin but no luck.
Is this a bug?

#12

manfer - July 7, 2009 - 21:20

which system, windows, Mac, linux...? which version 5.x or 6.x? With the images provided to test doesnt work or it is with your own images?

I would test more if needed but works fine for me on safari, firefox and didnt test opera but I dont think would be any problem to work on that browser too. Tested on linux and MacOSX.

I'm not sure what you report. You say on those browsers the mirror effect does not work only on big image when opening the peel but works on small image with the peel closed? Or mirror effect does not works at all in those browsers?

The later is really strange if it works on one but not in other. And only the big image mirror but big image is showing?

If it is what I understood is really really strange, not javascript problem because the big peel shows and hide when needed. The problem only could be on flash and the big one does not use any different than small one to do the mirror.

Well I now followed the link. I'm stupid not doing that as I saw it, lol. I'm seeing it properly with mirror on your site from firefox on MacOSX. Now you changed some configuration with no mirror on Safari, still working but with different configuration with no mirror.

Thanks for test report if you still have that issue and please confirm operating system and drupal version.

I have just worked more on module to provide the localization file (generic for any one who wants to traslate it to its language and spanish traslation just provided) by now this only for 6.x version, smooth shadows on flash this is valid for both versions, and corrected I bug I found when cloning the pageear that comes with the module for both versions.

#13

manfer - July 7, 2009 - 21:24

Tested now your site with Safari on MacOSX and with configuration you have now the mirror effect works fine on both close and open peel.

Do you still have that problem or you found the configuration problem?

#14

manfer - July 7, 2009 - 22:03

Well I see is failing as you say in opera linux. Really strange thing, I would work on that tomorrow to try to understand where it comes from.

On firefox linux saw that too and it is not an error on code in my case it is only because an ad blocker. The big image flash is called peel. What I dont understand is why it loads but not with mirror effect I supposed it to be totally blocked. Strange strange strange.

Maybe opera issue is just the same some ad blocker that comes with opera.

Ill try tomorrow to change all names that could be blocked by an ad blocker but of course this could be blocked by those kind of filters on future no matter how I name those files. It is a user preference to permit those ads or avoid them.

#15

manfer - July 7, 2009 - 22:21

opera linux worked fine too as soon as I configured firefox ad blocker to permit your site. Really strange that opera uses the firefox extension. ???

#16

danreb - July 8, 2009 - 02:35

Good day, I admire you for this piece of works that you made a GPL version of pageear, thanks for sharing this to the community.

Actually I am new to drupal and just exploring on this CMS at the moment.

Sir, I still don't see the mirror effects in the big image when the peel loads, I attached the screenshot in jpg format.

here's the environment info:

Drupal 6.13 installed in the linux server - I host my site in Softlayer Technology
I view it in Windows XP SP2 - my Operating System where all those browser was installed.
I used the provided image comes with the downloaded package.

I uploaded the module in my site using the built in ftp of Adobe Dreamweaver.
I'll also try to finds out what makes the big image don't show the reflection.

AttachmentSize
bigpeel.jpg 44.27 KB
smallpeel.jpg 14.02 KB

#17

danreb - July 8, 2009 - 05:21

The javascript configuration code that inserted by the pageear modules on every page throws an error when the page is validated in W3C, this is cause by un encoded ampersand on every peelQueryParams value.

I encoded all the & in every pellQueryParams and make my page validates XHTML strict (see the attached files).

I need a second opinion if this is the best way to correct this issue, I attached the modified pageear.module in text format (pageear.module.txt)

You can check it if it's correct, I am not actually a programmer.
I uploaded the changes to my website and it's works fine and my page passed W3C XHTML validation.

AttachmentSize
pageear.module.txt 14.68 KB

#18

manfer - July 8, 2009 - 12:40

Thanks for that advice I have made the proper changes on ampersands.

I think I have solved your issue too. Could you please test this to confirm?

http://cuentatemporal.byethost17.com/

I would like your opinion on that pageear in general too. Any suggestions would be wellcome.

Thanks.

#19

danreb - July 8, 2009 - 15:35

Yes this works, your demo page show the mirror image on the peel, I provided the screenshot in the attached jpg file.

What was the changes?

AttachmentSize
pagear-gpl.jpg 33.9 KB

#20

manfer - July 8, 2009 - 16:09

Code problem on flash. I thought I was correctly waiting for the media to load but was not. Only a minimal error on flash. Now the only problem could be if a user tries to open too soon the peel in that a situation would be a delay to show the big peel but I dont think any user is going to go so inmediatly to open the ad making the problem appear. After that first time it wouldnt be any problem because media is cached. But as I say the problem is going to appear in very very little uses.

I would try to code another function to show only the small peel when all media on big peel is loaded which solves that too.

I renamed some files and directories too to avoid to be blocked by some ad filters, by now.

#21

manfer - July 9, 2009 - 10:10

I uploaded the corrected version in a new issue if you want to change it.

I think now it is prepared to be released so if you can confirm it works fine I could now ask for permission to maintain the module.

- The new version has spanish localization and generic localization file so it can be localize to any language.
- PNG and GIF images are supported now. (static GIFs, animated GIF would only show first frame, a pity, this was why I did the change but I suppose to provide with animated GIF support I should have to change flash).
- Corrected ampesands as you suggested to conform DTD and validate.
- Added a fieldset to group close button color values.
- Flash an javascript corrected to preload all media before pageear appears on page (this can delay the pageear load first time but would prevent any error on media not proper loaded like the one with mirror effect you reported)
- Renamed some files and the module inner folder to avoid some ad filters that block "pageear" word.

Thanks for testing.

#22

danreb - July 9, 2009 - 15:37

I installed the updated module in the new issue but it only works in IE 6 and IE 7 browser and doesn't works in other browser at all,

troubleshooting the problem why this does'nt work lead me to pageTurn.js file.

I notice that you added an additional function in line 128

function showFlag(){
jQuery("#flagDiv").show();
}

which seem's doesn't work on those browser making the pageear not appear at all.

I tried to delete the additional declaration of style:none; in line 187
-----------------------------------
From this

  document.write('<div id="flagDiv" style="display:none; position:absolute; width:100px; height:100px; z-index:9999; ' + xPos + ':0px; top:0px;">'); 

To this

  document.write('<div id="flagDiv" style="position:absolute; width:100px; height:100px; z-index:9999; ' + xPos + ':0px; top:0px;">'); 

of pageTurn.js solve the problems and make's it works in all browser that i tested.

IE 6 and 7
Netscape 9
Opera 9.56
Safari 3.1.2
Firefox 3.5

You can see it works in my page http://drupal.danreb.com

It now used the updated pageear file and working on those browser, the only thing left that I noticed is the slight delay of showing the bigger image at hovering, this is only when first hover the magic corner.

Aside from this it all works fine in my observation.

Thanks.

#23

manfer - July 9, 2009 - 16:32

display:none is a css property that should work on all browsers. It hides the div layer with the flag motion small peel.

showFlag function is called when all media is loaded and would reveal that layer. The jquery used on that function should work in all browser. Jquery is a javascript framework prepared to work on all browsers and is included on drupal.

This is what solves the delay on the appearance of the big peel if you try to open the peel too soon.

With this change the peel wont show until all media is loaded. It would be a delay on first time to load the peel but the small peel now not the big peel which solves the problem.

Had you clean browsers cache before testing? If for some reason the flash on your browser where old ones (got from cache) and not new ones, the old ones have no call to showFlag function when all media is loaded and for that reason the peel would never show.

Could you please test the one in my test site? Please clean browsers cache before testing. I'm sorry I have to ask for this but it is very very important to be sure the new flash and js versions are being used. I'm almost sure the js is the correct one, drupal adds an ? follow by a random letter to the end of URLs I suppose just to avoid this kind of problems with cache.

http://cuentatemporal.byethost17.com/

Many thanks for your time to test it is of great help.

I could try to do the same to avoid cache for flash files but it would imply to change the adobe provided javascript to test for flash version which is the responsible to load the flash components too.

#24

manfer - July 9, 2009 - 19:32

OK I tested now in Windows and you are right again something is happening and it is not working in Windows.

I had tested in Firefox, Safari, Flock in Mac and Firefox, Opera in Linux and worked fantastic.

I dont understand what is wrong with Windows. This kind of things are so strange, working on firefox Mac and Linux versions but not on Windows one.

#25

manfer - July 28, 2009 - 12:04
Status:active» fixed

New realease of module 6.x-2.0 not depends anymore on and external third party non GPL project.

#26

System Message - August 11, 2009 - 12:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.