I deleted the items from this feed. I then set it to update in a day. It keeps resetting to be top of the planet.

Comments

Amazon’s picture

http://rufzeichen-online.de/taxonomy/term/6/feed. According to Drumm, the clock is set in the future. Removing the feed for now.

Kieran

eigentor’s picture

Ah sorry
What can I do? I just upgraded my site to D6, so maybe it is in my Aggregator settings?

I also noticed this but hoped it would stop :P

gábor hojtsy’s picture

Somehow your pubdate values are translated to German. They definitely should not be. My Safari browser detects all your items as if they were from today this very moment, because (I guess) it could not parse these dates:

<pubDate>Mo, 13 Apr 2009 02:56:59 +0200</pubDate>
<pubDate>Mi, 28 Jan 2009 04:56:26 +0200</pubDate>
<pubDate>Fr, 05 Dez 2008 05:38:19 +0200</pubDate>

These should be in the standard ISO format and not translated. My latest item dates for comparison from my planet aggregated feed:

<pubDate>Mon, 04 May 2009 12:25:24 +0000</pubDate>
<pubDate>Thu, 09 Apr 2009 11:20:30 +0000</pubDate>
<pubDate>Tue, 17 Mar 2009 13:47:43 +0000</pubDate>
...

Note the different day names, "Mon" vs "Mo" and your translated month names, like "Dez".

eigentor’s picture

Hm. Do I have to present the feed in english to archieve this?
On my old Drupal 5 site, I guess there just were no translations for Date names. So our thoroughness in translation may have tripped me...

At the moment the site is not a multilingual site but just in german. Does it need to be multilingual?

How do I read out the pub dates?

gábor hojtsy’s picture

This might be a contrib module bug or a PHP setting.

Drupal should not translate dates generated for XML feeds. The taxonomy feed is generated by taxonomy_term_page() and that reuses node_feed(). node_feed() uses gmdate() which is a PHP built-in function and therefore should not translate stuff via Drupal.

There is either a module which alters the feed data and adds in translated dates or your PHP is somehow configured so that gmdate() outputs translated data (however, http://php.net/gmdate does not say that the returned data could be localized). I'd suggest looking into these areas.

eigentor’s picture

Problem solved, please try to put me into the planet again. I had the same problem on the german planet, and it is solved there now.

This is a views bug. Am gonna post the solution for that, in the views queue this is the patch:

http://gist.github.com/111166

#
Index: modules/node/views_plugin_row_node_rss.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/views/modules/node/views_plugin_row_node_rss.inc,v
retrieving revision 1.6
diff -u -p -r1.6 views_plugin_row_node_rss.inc
--- modules/node/views_plugin_row_node_rss.inc  7 Apr 2009 22:02:40 -0000  1.6
+++ modules/node/views_plugin_row_node_rss.inc  13 May 2009 18:03:16 -0000
@@ -98,7 +98,7 @@ class views_plugin_row_node_rss extends
     $extra = node_invoke_nodeapi($node, 'rss item');
     $item->elements = array_merge($extra,
       array(
- array('key' => 'pubDate', 'value' => format_date($node->created, 'custom', 'r', variable_get('date_default_timezone', 0))),
+ array('key' => 'pubDate', 'value' => gmdate('r', $node->created - variable_get('date_default_timezone', 0))),
         array(
           'key' => 'dc:creator',
           'value' => $node->name,

gábor hojtsy’s picture

I'd say you should just use $node->created without the timezone munging, since this GMdate, that is GMT timezone, and $node->created is stored in that and calculated for users with that timezone setting.

eigentor’s picture

hehe I did not write the patch... (dereine did) it is just a quick fix. we'll better discuss this with merlin in the views issue qeue...

This is the issue http://drupal.org/node/461842

dawehner’s picture

ok that was my fault

i just read this line

<?php
      $date .= format_date($timestamp - $timezone, 'custom', 'D, d M Y H:i:s O', $timezone, $langcode);
?>
eigentor’s picture

Both patches solve the Problem. I think you can safely add me to the feed again, Gabor.

gábor hojtsy’s picture

Status: Active » Fixed

Added back. Since you do not have recent posts on the feed now that the dates are correct, no new posts are showing from you on top, but your older posts are there with the right time now.

eigentor’s picture

April 12, post is there. All is fine :) thx

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.