Install problem with PANELS_REQUIRED_CTOOLS_API

its definied on the top of

panels.module

define('PANELS_REQUIRED_CTOOLS_API', '1.0.1');

I'm surprised that the requirements do not pass, though. I updated the demo site to -dev just a couple of nights ago, both using 1.0.1 and it *does* pass, so I am a little confused.

I have experienced the same behavior that drupal24 noted in his post.

Hm. Yes, it would appear that the install process does not load the .module file. That is obnoxious, as I thought it did. Not sure how to fix this offhand. Redefining the constant is a bad one, as then the version # has to be in 2 places and that's got a high chance of breaking.

Ok, I believe I have this all fixed in Panels CVS now.

@drupal24: the problem with using it in an installation profile is that the system table does not exist, therefore it cannot find the path to the directory, e.g.:

Warning: Table 'drupal_blah.system' doesn't exist query: SELECT filename FROM system WHERE name = 'panels' AND type = 'module' in /blah/trunk/includes/database.mysql.inc on line 128

What might be worth doing is checking for whether one of the site installation functions, e.g. "install_verify_drupal", exists as that should only ever be available during site installation vs normal module installation. Of course, at that point I'm not sure how it could verify the paths without doing some crazy code?

Damien

FYI, what I did to limp through this was to change line 9 in panels.install to the following:

  if ($phase == 'install' && !function_exists('install_verify_drupal')) {

Definitely not a clean fix, but it at least allowed me to add Panels to an installation profile.

drupal24: glad to be able to help, though obviously what I provided should be considered a band-aid at best, it really needs a proper fix.

Does something like this fix this? (I don't have a profile handy to test with:)

  if (!db_is_active()) {
    $path = dirname(drupal_get_filename('module', 'panels', NULL));
    require_once './'. $path .'/panels.module';
  }

If possible I'd like to have this fixed for the rc coming up soon. Anyone with an install profile handy to test?

merlinofchaos: To verify what was going to be available, I changed the panels_requirement to the following to see what would happen:

function panels_requirements($phase) {
  $requirements = array();
  $t = get_t();
  if ($phase == 'install') {
    print drupal_get_filename('module', 'panels', NULL) . "<br />";
    print drupal_get_path('module', 'panels') . '/panels.module' . "<br />";
    print drupal_get_path('module', 'ctools') . '/ctools.module' . "<br />";
    die('sleep is for the weak');
..

It gave the following error:

( ! ) Warning: Table 'mysite.system' doesn't exist query: SELECT filename FROM system WHERE name = 'panels' AND type = 'module' in mysite/includes/database.mysql.inc on line 128

Next idea? Would it be too crazy to search the entire directory structure to find "ctools.module"?

Another test.

I inserted the code provided so it looks like:

function panels_requirements($phase) {
  $requirements = array();
  $t = get_t();
  if ($phase == 'install') {
    if (!db_is_active()) {
      $path = dirname(drupal_get_filename('module', 'panels', NULL));
      require_once './'. $path .'/panels.module';
    }

    // apparently the install process doesn't include .module files,
    // so we need to force the issue in order for our versioning
    // check to work.
    if (!defined('PANELS_REQUIRED_CTOOLS_API')) {
      include_once drupal_get_path('module', 'panels') . '/panels.module';
    }

    // In theory we should check module_exists, but Drupal's gating should
    // actually prevent us from getting here otherwise.
    if (!defined('CTOOLS_API_VERSION')) {
      include_once drupal_get_path('module', 'ctools') . '/ctools.module';
    }
    if (!module_invoke('ctools', 'api_version', PANELS_REQUIRED_CTOOLS_API)) {
       $requirements['panels_ctools'] = array(
         'title' => $t('CTools API Version'),
         'value' => CTOOLS_API_VERSION,
         'severity' => REQUIREMENT_ERROR,
         'description' => t('The CTools API version is too old for Panels. Panels needs at least %version.', array('%version' => PANELS_REQUIRED_CTOOLS_API))
       );
    }
  }
  return $requirements;
}

This results in the following error:

( ! ) Warning: Table 'mysite.system' doesn't exist query: SELECT filename FROM system WHERE name = 'panels' AND type = 'module' in /Users/dmckenna/Sites/mysite/includes/database.mysql.inc on line 128
Call Stack
#	Time	Memory	Function	Location
1	0.0058	386044	{main}( )	../install.php:0
2	0.0086	563132	install_main( )	../install.php:1174
3	0.1729	5777528	install_check_requirements( $profile = 'scubadiving', $verify = TRUE )	../install.php:109
4	0.1729	5779076	drupal_check_profile( $profile = 'scubadiving' )	../install.php:914
5	19.1133	8018192	module_invoke( 'panels', 'requirements', 'install' )	../install.inc:692
6	19.1133	8018816	call_user_func_array ( 'panels_requirements', array (2 => 'install') )	../module.inc:450
7	19.1133	8018880	panels_requirements( $phase = 'install' )	../module.inc:0
8	19.1133	8019876	drupal_get_path( $type = 'module', $name = 'panels' )	../panels.install:20
9	19.1133	8020036	drupal_get_filename( $type = 'module', $name = 'panels', $filename = ??? )	../common.inc:1936
10	19.1134	8021328	db_query( $query = 'SELECT filename FROM {system} WHERE name = \'%s\' AND type = \'%s\'', 'panels', 'module' )	../bootstrap.inc:440
11	19.1135	8023096	_db_query( $query = 'SELECT filename FROM system WHERE name = \'panels\' AND type = \'module\'', $debug = ??? )	../database.mysql-common.inc:42
12	19.1140	8025240	trigger_error ( 'Table 'mysite.system' doesn't exist\nquery: SELECT filename FROM system WHERE name = 'panels' AND type = 'module'', 512 )	../database.mysql.inc:128

FYI line 20 is:

      include_once drupal_get_path('module', 'panels') . '/panels.module';

Seems there's a cleaner way of identifying whether running an installation profile after all.

DamienMcKenna, panels-n460902.patch works well for me. Thanks.

Committed! THanks!

I got the same.
Thanks for the fix.

FTR, I've usually used :

require_once( dirname(__FILE__) . '/required.inc' );

before the days of module_get_include when I needed a nearby file. Saves trusting the absraction layer or requiring a database hit etc etc. Sometimes simple is simpler.