This is probably my fault due to funky markup and css from HEAD, but check the eldir vs non eldir pics.

this is a critical issue, as it's one of the things i specifically need to cover in the install screencast.

CommentFileSizeAuthor
#6 Queue admin form in Firefox105.35 KBomega8cc
#6 Queue admin form in Safari100.85 KBomega8cc
#6 Queue admin form in Chrome99.54 KBomega8cc
#4 eldir-hardcore-fix.patch1.17 KBomega8cc
#3 0001-460974-improving-queue-admin-form.patch1.18 KBPls
#3 queue_admin_form_before.jpg39.95 KBPls
#3 queue_admin_form_after.jpg40.97 KBPls
Garland32.16 KBadrian
eldir31.76 KBadrian

Comments

yhahn’s picture

yhahn commented

http://drupal.org/cvs?commit=210674

I've put in a stopgap fix for now but it's not as good as it could be. We should revisit this and the larger general issue here -- limited real estate for forms that could use a bit more room.

One option would be to switch to a fluid layout, but Eldir is currently at 960 which is what a good portion of users will max out at anyway even with fluid width. Other options worth exploring might be to look at alternative layouts that don't use 2 columns/sidebars for navigation/status blocks.

anarcat’s picture

anarcat commented
Priority: Critical » Normal
Status: Active » Needs work

I'm not sure the larger issue belongs here, but at any rate, the original bug is 'fixed enough' so that we can release hence I'm downgrading this to 'normal'.

Pls’s picture

Pls commented
Title: queue admin form broken » improve queue admin form
Version: 5.x-0.2-alpha1 » 6.x-0.4-alpha3
Assigned: Unassigned » Pls
Status: Needs work » Needs review
StatusFileSize
new queue_admin_form_after.jpg40.97 KB
new queue_admin_form_before.jpg39.95 KB
new 0001-460974-improving-queue-admin-form.patch1.18 KB

I checked original bug report and it seems fixed. Now added a patch to improve queue admin form. Feedback is appreciated. Screens attached - before and after. Thanks.

omega8cc’s picture

omega8cc commented
Status: Needs review » Needs work
StatusFileSize
new eldir-hardcore-fix.patch1.17 KB

This Eldir patch works fine for Chrome, but not for Safari, where the "sites every" is displayed *after* (on the right) all the form fields (for Cron queue) instead of above them. Not sure how to fix this in CSS since the text is not wrapped in any div or span, so I'm attaching a patch to show where is the problem (however it is not a solution, probably).

steven jones’s picture

steven jones commented
Project: Eldir » Hostmaster (Aegir)
Version: 6.x-0.4-alpha3 » 6.x-2.x-dev
Assigned: Pls » Unassigned

This is still an issue in the latest version of Eldir, and should be an easy fix I reckon.

omega8cc’s picture

omega8cc commented
StatusFileSize
new Queue admin form in Chrome99.54 KB
new Queue admin form in Safari100.85 KB
new Queue admin form in Firefox105.35 KB

I think we have it fixed in our Eldir fork: http://drupalcode.org/sandbox/omega8cc/1074912.git/blob/HEAD:/themes/eld...

This forked version includes fixes even for some popular contrib modules, as you can see.

I'm attaching the screenshots from Firefox, Safari and Chrome.

omega8cc’s picture

omega8cc commented

So, I guess we should submit a proper patch for review.

steven jones’s picture

steven jones commented
Status: Needs work » Fixed

I've re-worked the CSS on this form so that it applies generically and doesn't need fixing up for each queue in 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a78a79a on 599758_edit_main_site, 640952_client_preview, dev-dns, dev-features, dev-headless_install, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newsiteform, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-relationships, dev-restore, dev-server_nodetype, dev-services, dev-site_rename, dev-ssl, dev_dns, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x authored by yhahn: 
    #460934: Fix for autocomplete throbber position. #460658: Fix for admin/...
  • Commit 49bdccd on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #460974 by Steven Jones: Fixed improve queue admin form.

  • Commit a78a79a on 599758_edit_main_site, 640952_client_preview, dev-dns, dev-features, dev-headless_install, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newsiteform, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-relationships, dev-restore, dev-server_nodetype, dev-services, dev-site_rename, dev-ssl, dev_dns, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x authored by yhahn: 
    #460934: Fix for autocomplete throbber position. #460658: Fix for admin/...
  • Commit 49bdccd on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #460974 by Steven Jones: Fixed improve queue admin form.