Posted by recidive on May 13, 2009 at 6:05am
4 followers
| Project: | ImageCache |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The imagecache_create_url() function calls url() setting $query to FALSE rather than to NULL, this is causing url() to add a trailing '?' in URLs when $bypass_browser_cache = FALSE (default).
Attached patch corrects this.
Note: patch taken from imagecache.module file, since I did this change in SVN of one of my projects in a rush.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| imacache_querystring.patch | 689 bytes | Ignored: Check issue status. | None | None |
Comments
#1
I can confirm that the patch works as described.
I did the same change before finding this issue.
#2
@riccardoR: thanks.
Setting this to RTBC.
#3
Can we get this one liner commited?
#4
realized it was a problem in 6 as well and just back ported the patch i'd rolled for that to 5.
#5
committed to HEAD and DRUPAL-5--2
#6
Automatically closed -- issue fixed for 2 weeks with no activity.