Download & Extend

messaging_xmpp - message not sending.

Project:Messaging
Version:6.x-4.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

im running 6.x.2.0 now.

xmpp messages wont send.

messaging_xmpp_messaging gets executed, as it should.

messaging_xmpp_send_msg never gets executed.

I'm not sure how the new callbacks are working, but im guessing the error is in the api somewhere..

i'll look further into it.

Comments

#1

actually it looks like none of the callbacks are being executed - i added watchdog entries at the start of messaging_xmpp_render and messaging_xmpp_user_destination and neither are called.

#2

Status:active» postponed (maintainer needs more info)

The presence part of xmpp is not properly handled yet so make sure the user has an xmpp account (xmpp_user) and the option is "send anyway".

Also, you can try messaging_debug to make sure your settings are ok and xmpp messages get out. Check also the watchdog log for xmpp errors.

#3

Status:postponed (maintainer needs more info)» closed (fixed)

No follow up, so closing.

#4

Status:closed (fixed)» active

Can you say more about "The presence part of xmpp is not properly handled yet" ? Is it just that this functionality is lacking in the XMPP Framework module?

I have two ideas for addressing it - hide it, or work around.

To hide it, I would just use hook_form_alter and remove those options to avoid user confusion.

To work around, our XMPP server is OpenFire and there is an http presence API. I could write a module to check it and call it from messaging. Is it worthwhile for me to do this, or is there something I'm missing?

#5

Version:6.x-2.0» 6.x-4.x-dev
Priority:normal» critical
Status:active» needs review

Can be solved by this patch in the 6.x-4 version. Might be similar in 6.x-2: please verify and report.

This function should be updated the same way messaging_sms did to include Object programming approach in 6.x-4 version:

/**
* Message Render callback
*/
function messaging_xmpp_render($message, $info) {
  // rendering the message to get any additional pieces being put on

//  $message = messaging_message_render($message, $info);
  $message = Messaging_Send_Method::default_render($message, $info);

  // We apply a final filterting, stripping out all html tags
  $message->body = messaging_text_clean($message->body);
  $message->subject = messaging_text_clean($message->subject);
  return $message;
}

#6

Status:needs review» reviewed & tested by the community

#5 Fixed the problem for me

#7

Status:reviewed & tested by the community» fixed

Fixed. Thanks.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.