Closed (outdated)
Project:
Quick Tabs
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
13 May 2009 at 10:01 UTC
Updated:
19 May 2020 at 19:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pasquallenice functionality, thanks for sharing
quick review:
the $(document).ready() could be changed to a Drupal.behavior http://drupal.org/node/205296
the script probably does not work with more quicktabs on the same page as you selected the tabpages directly, not the quicktab wrapper
and also does not work with ajax quicktabs
if you would like to remove the loop in the periodicRefresh function, then check the quicktabsClick function where the change of "active" class and showing the active tabpage is done much more clearly..
we should probably add functionalities like this to the 3.x version. I am thinking about a more robust quicktab style settings, where it would be possible to add additional js files to the style, and set style specific setting like the rotation interval.. #351008: Style improvements
Comment #2
nick_vhYou're right!
But it was for a quickfix solution
Hope I find time to make it a but more solid like you proposed.
More quicktabs on the same page doesn't work indeed, there's also no configuration for it yet. Good idea though. I couldn't make the ajax working anyway (programmattically coded quicktabs) so that was no issue here.
If we plan to make this more generic this is an issue to look into.
And i'll look into the quicktabsClick function, I don't like the loop no :-)
Comment #3
jacobson commentedI would heartily endorse adding the rotate capability to Quick Tabs, which is a superb module. Some sort of combination of Quick Tabs and JCycle would be terrific. I have no skills in coding at that level, but I'd help test it.
Comment #4
eL commentedAny news about autorotation?
Tried Nick_vh module, it works, but if I click on a tab manualy, it is not showed properly :( AJAX is turned off... but i am using 2 RC5 version. Should I use DEV version?
UPDATE: same problem with DEV version. Click works OK only if rotation is not started. After this, clics doesnt work at all.
Comment #5
eL commentedno one? it is only one last thing causing that this module is not perfect :(
Comment #6
nick_vheL, could you mail me with your problem or talk to me on IRC, let's see if we can solve your problem. But without a concrete error or more examples here we will not get anywhere.
Probably we will have to adjust some of the jquery :-)
Comment #7
eL commentedThanks, you have e-mail from me.
Here is my helper module, based on your code.
Comment #8
eL commentedHere is a solution, which works fine: http://drupal.org/node/264299
Comment #9
escoles commentedWhen I use the JavaScript from #7, I get some peculiar results:
If the height of
quicktabs-mainis set to an explicit value in the stylesheet, clicking on a tab causes that tab to display below the main quicktab (see screen clip, attached).The tab display remains in this state until rotation passes the tab corresponding to the one you clicked on, then again displays a single pane. After doing this several times, display can get quite mangled for a rotation, then seems to return to normal.
Also, typically when you click on a tab other than the one currently being displayed, both tabs are shown as selected (see second screenshot).
Display does NOT pause (not sure if it's supposed to).
Comment #10
miccil commentedSome small fixes for this js snippet
1) Terminate rotation on user click
2) Using click event trigger for activating tab
Comment #11
avpadernoI am closing this issue, since it's for a Drupal version no longer supported.