Just upgraded to 1.7 and clicked a print link... white screened. Tried pdf link, same result.
Error log shows the following...

[13-May-2009 12:33:09] PHP Fatal error: Call to undefined function drupal_final_markup() in /home/myfolder/public_html/dev/sites/all/modules/print/print.pages.inc on line 34

[13-May-2009 12:33:18] PHP Fatal error: Call to undefined function drupal_final_markup() in /home/myfolder/public_html/dev/sites/all/modules/print/print_pdf/print_pdf.pages.inc on line 68

Not sure what other info would help here.
I went back to 1.6 and things seem to work fine with that version.

Comments

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Fixed

Wow, so you upgrade the print module as soon as it's released, but you're not using the latest version of Drupal itself.

Upgrade Drupal and you should be fine.

João

aharown07’s picture

aharown07 commented

Got me there. 6.10 is already too old eh? Should get a chance to do that in a few days.

jcnventura’s picture

jcnventura
Primary language English
commented
Title: fatal error when click print or pdf link - after upgrade to 6.x.-1.7 » undefined function drupal_final_markup - print 6.x.-1.7 requires Drupal >= 6.11 / print 5.x.-4.7 requires Drupal >= 5.17

Yes, and Drupal is already in 6.12.. The drupal_final_markup is an ugly fix for an XSS vulnerability in Drupal <= 6.10 that was also present in the print module. Because 1.7 was a security release for that same vulnerability the solution to re-use the fix in core Drupal was the easiest to implement and to get approval by the security team.

aharown07’s picture

aharown07 commented

Makes sense. Thanks for the info.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

exit44’s picture

exit44 commented

I inherited a drupal theming project about half way through and am not sure what version it was. I upgraded to 6.11 and this problem immediately went away.

alextronic’s picture

alextronic commented

I have Drupal 6.12 (that's what my status report says)

I have Print 6.x.-1.7 module installed (that's what the module's README.txt says)

I get the error... Why?!

jcnventura’s picture

jcnventura
Primary language English
commented

If you're getting the "undefined function drupal_final_markup" error, I am 99.9% sure that whatever you have in there is not really Drupal => 6.11, even if the status report says otherwise. That function was introduced in Drupal 6.11, so if you really have 6.12 this error should never appear.

João

alextronic’s picture

alextronic commented

You're absolutely right.

I uploaded to 6.13 and the error is gone.

(don't know why Drupal's Status Report gives wrong information about itself).

Anyway -- thanks for the hint!

A.