Suggestions for link_codes
Gribnif - May 13, 2009 - 21:23
| Project: | Share |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Attached is a patch that contains some suggestions for link_codes:
1. Use the url() function, so that the generated code works with https: servers.
2. Don't say, "Click here to view", since that's considered bad practice.
3. Make the "View [title]" strings translatable. As a side-benefit, run the $node->title through check_plain().
4. Simplify the code a bit, by removing some redundancy.
| Attachment | Size |
|---|---|
| share-link_codes.patch | 2.43 KB |
#1
Thanks, I made a tiny change to your patch that passes a path alias inside of the url() instead of defaulting to 'node/##'. I'd like to default to the path alias and possibly make a setting allowing to not use the path alias.