Attached is a patch that contains some suggestions for link_codes:
1. Use the url() function, so that the generated code works with https: servers.
2. Don't say, "Click here to view", since that's considered bad practice.
3. Make the "View [title]" strings translatable. As a side-benefit, run the $node->title through check_plain().
4. Simplify the code a bit, by removing some redundancy.

CommentFileSizeAuthor
#1 link_codes.diff2.24 KBgreenskin
share-link_codes.patch2.43 KBgribnif

Comments

greenskin’s picture

greenskin commented
StatusFileSize
new link_codes.diff2.24 KB

Thanks, I made a tiny change to your patch that passes a path alias inside of the url() instead of defaulting to 'node/##'. I'd like to default to the path alias and possibly make a setting allowing to not use the path alias.

greenskin’s picture

greenskin commented
Status: Needs review » Reviewed & tested by the community

In favor of @Gribnif's original patch.

spgd01’s picture

spgd01 commented

Wow this is old. I am in favor of the patch. It should be in the new release by now. Any progress?