This patch prevents the submit and form_id array elements being saved to the data column on user registration.

CommentFileSizeAuthor
#6 unset_0.patch449 byteschx
#3 unset.patch427 byteschx
user.module_23.diff852 bytesdrumm

Comments

moshe weitzman’s picture

moshe weitzman commented

gosh, this bug again. we've seen it with system_settings and one other place. there are a few more system variables which might need to be unset() see http://drupal.org/node/41170. maybe we can do the unset() in a central place and then both of these issues will use that code?

dries’s picture

dries commented

+1 for fixing this in a central place.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new unset.patch427 bytes
dries’s picture

dries commented

Can we clean up some code in system.module too?

NaX’s picture

NaX commented

I was looking in the PHP manuals at the unset function just before reading this issue and I would like to know if you want to unset these variables globally or locally.

If you in a function and you use unset() it only destroys the local version of the variable even if it is passed by reference.

To unset the global version of the variable you need to unset it using the $GLOBALS array. So my question is how do you want to unset these variables. Globally or locally, or is that unimportant.

chx’s picture

chx commented
StatusFileSize
new unset_0.patch449 bytes

NaX is right. Dries, there is nothing to clean up in system. This fixes (partially) the issue moshe talks of.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)