'content' cannot be used as a $form element and breaks any page which uses it, such as admin/settings/statistics

I reviewd the patch:
before aplying the patch when visting:

admin/settings/statistics (after enabeling statistics of course)

garland is gone

after aplying the patch and going to

admin/settings/statistics the page looks like one would expect...

so the patch fixes the reported bug !!!

did some playing arround with the settings of statistic module works fine for me...
since only the the form array is changed from "content" to "counter" i don't see any coding style brocken..

but since I this is only my third patchreview I leave that on needs review
(unless sombody tells me that the review was sufficent)

Spuky

since I got no feedback

I am setting this one to rwtbtc still not shure if my review was sufficent

Spuky

Works for me, but I think we need a test for this - test both should have picked up the breakage already.

I was thinking about a Test too, but what would you test on. The test for this error would have to be run for every form in core because today it is statistics.module that has the $form['content'] array element defined. But next week maybe sombody in the comment.module or any other module defines a $form['content'] element so statistics.module would be working fine and testing for beeing fine but a totaly different module is broken somewhere... and not testing for that error.

So If we need a test for that case I think It should be a more general Test that is not bound statistics.module.

Maybe it would be more kind of a coder module feature to check for this edgecase since this issue will hit contrib developers even more likely than core developers.

maybe I was thinking in to big context. The test should just test the Fact if config page could be accessed without error. I will try writing that test Tonight.

Spuky

Yes I meant just a basic test to ensure the statistics settings page works properly.

So here is a version including test for accessing setting page... since that is my first test somebody might want to look closely if I got it all right...

Patch works OK and fixes broken administration page but code-wise it still needs some work.

• The closing brace in the following snippet is not placed correctly and there should be a space between the , sign and 'administer statistics'.

  function setUp() {
    parent::setUp('statistics');
    $this->settingpage_user = $this->drupalCreateUser(array('access statistics','administer statistics'));
    }
  

• The comments should contain a . at the end of a sentence and so do the assert text messages.

fixed coding style

This is fixed more elegantly at #428744: Make the main page content a real block