Comments in the code (gmap.module:887) said "doesn't belong here. Theming needs to get fixed instead..". And because I needed to control this from within my theme, I went ahead and patched this.

CommentFileSizeAuthor
#11 interdiff.txt1.81 KBhog
#11 gmap_port-features_463356_10.patch1.66 KBhog
#9 gmap_port-features_463356_9.patch1.45 KBhog
#7 gmap_port-features_463356_7.patch4.96 KBhog
#5 gmap_port-features_463356_5.patch1.41 KBhog
#4 gmap_port-features_463356_4.patch1.41 KBhog
gmap-theme_gmap_popup.patch1.41 KBtobiassjosten

Comments

tobiassjosten’s picture

tobiassjosten commented

I did briefly consider #285143: Theming the GMap info windows but that seems to be more of an issue concerning some template file.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

all feature requests can be imported in 6.x version after committing em in major versions with backport afterwards
Can You make this ?

hog’s picture

hog commented
Assigned: Unassigned » hog
Issue summary: View changes
hog’s picture

hog commented
StatusFileSize
new gmap_port-features_463356_4.patch1.41 KB

Changes port to 7.x.
In this patch also fix this issue: #348804

hog’s picture

hog commented
Status: Needs work » Needs review
StatusFileSize
new gmap_port-features_463356_5.patch1.41 KB

Review patch.

Status: Needs review » Needs work

The last submitted patch, 5: gmap_port-features_463356_5.patch, failed testing.

hog’s picture

hog commented
Status: Needs work » Needs review
StatusFileSize
new gmap_port-features_463356_7.patch4.96 KB

Fix patch file.

Status: Needs review » Needs work

The last submitted patch, 7: gmap_port-features_463356_7.patch, failed testing.

hog’s picture

hog commented
Status: Needs work » Needs review
StatusFileSize
new gmap_port-features_463356_9.patch1.45 KB

Fix patch file syntax.

Status: Needs review » Needs work

The last submitted patch, 9: gmap_port-features_463356_9.patch, failed testing.

hog’s picture

hog commented
StatusFileSize
new gmap_port-features_463356_10.patch1.66 KB
new interdiff.txt1.81 KB
hog’s picture

hog commented
Status: Needs work » Needs review
hog’s picture

hog commented
hog’s picture

hog commented
Assigned: hog » Unassigned

The last submitted patch, gmap-theme_gmap_popup.patch, failed testing.

The last submitted patch, 4: gmap_port-features_463356_4.patch, failed testing.