Feature requested: The administrator / configurable users should be notified of new booking requests.

CommentFileSizeAuthor
#1 publicbookings.463534.patch6.4 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new publicbookings.463534.patch6.4 KB

Please review the attached patch.

--edit: It allows to set a *single* email address, that will receive a copy of *each email* send regarding bookings (including confirmation emails). An implementation using a notification framework (or something similar) is planed, but will not be implemented in the near feature.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Adopted status.

ballerjones’s picture

ballerjones commented

Hello tirsales,

The patch works well, however, after a user creates a booking the server prints a log of the action taken. For my users, this is very confusing. Can I quickly disable this? I noticed Smtp module has a similar feature (only if option is selected).

sorry for being such a bother, I hope my annoyingness is helping refine this module, if even minimally.

Anonymous’s picture

Anonymous (not verified) commented

"prints a log"?

Do you mean the short text like e.g.

Your booking request asdsad has been submitted.

A confirmation link has been sent to your email address. Check your email and visit the link to proceed.

If yes: Please open a new issue for this ;)
If you mean the content of the mail send to the admin: It stays here.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (won't fix)

This patch will not be continued. Please see issue #468720: Integration with Rules, Notifications and Action/Trigger.

Anonymous’s picture

Anonymous (not verified) commented
Status: Closed (won't fix) » Closed (duplicate)

Apologies, wrong status. "Duplicate" of #468720: Integration with Rules, Notifications and Action/Trigger

ballerjones’s picture

ballerjones commented

No, by print a log I mean it prints: 

"SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready " 
SMTP -> get_lines(): $data is "220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready " 
SMTP -> FROM SERVER:220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "250-mail.lomira.k12.wi.us " 
SMTP -> get_lines(): $data is "250-mail.lomira.k12.wi.us " 
SMTP -> get_lines(): $data was "250-mail.lomira.k12.wi.us " 
SMTP -> get_lines(): $str is "250-AUTH LOGIN " 
SMTP -> get_lines(): $data is "250-mail.lomira.k12.wi.us 250-AUTH LOGIN " 
SMTP -> get_lines(): $data was "250-mail.lomira.k12.wi.us 250-AUTH LOGIN " 
SMTP -> get_lines(): $str is "250-8BITMIME " 
SMTP -> get_lines(): $data is "250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME " 
SMTP -> get_lines(): $data was "250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME " 
SMTP -> get_lines(): $str is "250-SIZE " 
SMTP -> get_lines(): $data is "250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME 250-SIZE " 
SMTP -> get_lines(): $data was "250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME 250-SIZE " 
SMTP -> get_lines(): $str is "250 DSN " 
SMTP -> get_lines(): $data is "250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME 250-SIZE 250 DSN " 
SMTP -> FROM SERVER: 250-mail.lomira.k12.wi.us 250-AUTH LOGIN 250-8BITMIME 250-SIZE 250 DSN 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "334 VXNlcm5hbWU6 " 
SMTP -> get_lines(): $data is "334 VXNlcm5hbWU6 " 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "334 UGFzc3dvcmQ6 " 
SMTP -> get_lines(): $data is "334 UGFzc3dvcmQ6 " 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "235 Authentication successful " 
SMTP -> get_lines(): $data is "235 Authentication successful " 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "250 Ok " 
SMTP -> get_lines(): $data is "250 Ok " 
SMTP -> FROM SERVER:250 Ok 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "250 Ok " 
SMTP -> get_lines(): $data is "250 Ok " 
SMTP -> FROM SERVER:250 Ok 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "354 Enter mail, end with "." on a line by itself " 
SMTP -> get_lines(): $data is "354 Enter mail, end with "." on a line by itself " 
SMTP -> FROM SERVER:354 Enter mail, end with "." on a line by itself 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "250 Ok " 
SMTP -> get_lines(): $data is "250 Ok " 
SMTP -> FROM SERVER:250 Ok 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "221 mail.lomira.k12.wi.us Closing transmission channel " 
SMTP -> get_lines(): $data is "221 mail.lomira.k12.wi.us Closing transmission channel " 
SMTP -> FROM SERVER:221 mail.lomira.k12.wi.us Closing transmission channel 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready " 
SMTP -> get_lines(): $data is "220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready " 
SMTP -> FROM SERVER:220 mail.lomira.k12.wi.us GroupWise Internet Agent 7.0.3 Copyright (c) 1993-2008 Novell, Inc. All rights reserved. Ready 
SMTP -> get_lines(): $data was "" 
SMTP -> get_lines(): $str is "250-mail.lomira.k12.wi.us " 
etc etc

and nothing else, the page is gone.

Anonymous’s picture

Anonymous (not verified) commented
Title: Notify administrator of new booking requests. » Strange Log after creation of a new booking
Category: feature » bug
Status: Closed (duplicate) » Postponed (maintainer needs more info)

This looks like a log by the SMTP module, not by Public Bookings or Bookings API.

I've taken the liberty to re-address this issue to the log-problem.

ballerjones’s picture

ballerjones commented
Status: Postponed (maintainer needs more info) » Fixed

duh - you were right. disabled smtp debugging.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.