Clicking the preview button when you have the node context comment form (panels has a custom comment form called panels_comment_form), you are redirected back to the same page, and the preview is shown, but you also see ALL the panes now, including the ones that tabs was supposed to be hiding. My guess is that a class name is changed or something when there is a comment preview.

Comments

frankcarey’s picture

frankcarey commented

This is also happening when a user just submits a comment. The comment is given an anchor of "#new", and the submit redirects to that anchor.

i.e. submit my comment -> mysite.com/node/1#new

so, it looks like the js is picking up #new when it shoudn't be

Frank

frankcarey’s picture

frankcarey commented
Title: using preview button on panels_comment_form show all content » using preview button on panels_comment_form breaks tabs, shows all content below tab
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: User interface » Code

Yep, that sounds like how it currently — erroneously — works. Also see http://drupal.org/node/296373#comment-1625446, which fixes a current bug in fragment checking. Just add another test that checks if the fragment is one of Tabs Panel Style and you should be good. Care to roll the patch? :)

frankcarey’s picture

frankcarey commented

i can give it a shot, is the code in question in the JS ?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yes. And … awesome, looking forward to the patch! :)

shaneonabike’s picture

shaneonabike commented

subscribe

smoothify’s picture

smoothify commented
Status: Active » Fixed

Marking this as fixed as I can't reproduce this behaviour on the current versions, the preview comments seems to work ok - please let me know if it does still occur.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.