Closed (duplicate)
Project:
Drupal core
Version:
x.y.z
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2006 at 19:04 UTC
Updated:
21 Feb 2006 at 10:06 UTC
I installed htmlarea and it was silently failing until I debugged and found out that module_list() was trying to load from the wrong directory.
This patch simply adds an else statement to the file_exists() check and spits out a watchdog error if the module file cannot be loaded.
| Comment | File | Size | Author |
|---|---|---|---|
| module-file-missing.patch | 634 bytes | samo |
Comments
Comment #1
moshe weitzman commentedlooks good. this has bitten me too. with the sites dir we now have a few choices about where to put modules/themes. easy for drupal and admin to get confused.
Comment #2
dries commentedI don't know when this would happen/trigger. How to reproduce?
Comment #3
moshe weitzman commentedLets say that you launch with just 1 site and put your contrib module packages in /modules. Then you go multi-site and move the packages to sites//modules as your location. Your modules will not load and admin gets confused. I'm not sure if the modules checkbox will be checked or unchecked in this case. Still, a watchdog is useful as an indication whenever an active module is unabel to be found. thats a significant error condition.
Comment #4
samo commentedMy scenario was very similar to Moshe's: I installed htmlarea under modules, then removed htmlarea, several months later I re-installed htmlarea under modules/htmlarea.
Comment #5
dries commentedRelated to http://drupal.org/node/48025 ?
Comment #6
Steve Simms commentedYes, this appears to be the same problem, with different solutions. I think a combination of both would be good.
Should this patch also remove the entry from the system table? Otherwise, it could produce a lot of watchdog messages, with no way of getting rid of them except putting the module/theme back (which may not be desirable) or editing the system table by hand (which may not be possible, and definitely wouldn't be desirable).
What would be the consequences of removing the entry?
Comment #7
dries commentedPlease mark one of the issues as duplicate, and continue with one issue instead. Let's go with the solution that has the smallest performance penalty, or that is otherwise considered to be cleanest. I want you guys to figure out the best approach. :)
Comment #8
Zen commentedMarking this issue as the dupe.
-K