URL is not properly generated + uploaded files disappear

Hi,

I noticed that the uploaded form files disappear after a while and the URLs of uploaded files are shown as an internal absolute path which leads to broken links. (I'm using private file system.)

The first issue seems to be happening because of calling file_save_upload() without calling file_set_status() makes the uploaded files temporary and cleaned by Drupal(http://api.drupal.org/api/function/file_save_upload/6)

The second issue is caused by local method fillpdf_fix_url() and use of generic file_create_url() is fixing it.

214,221d213
< function fillpdf_fix_url($url){
<       $url = rtrim(ltrim($url, '/'), '/');
<       if (!valid_url($url, TRUE)) { //if they used drupal-relative URL
<         $url = 'http://'. $_SERVER['SERVER_NAME'] .'/'. $url;
<       }
<       return $url;
< }
<
226,229d217
<   if($url=$form_state['values']['url']){
<       $url=fillpdf_fix_url($url);
<       form_set_value($form['pdf']['url'], $url, $form_state);
<   }
237a226
>           file_set_status($file,1);
245c234
<       $form_state['values']['url']=fillpdf_fix_url($file->filepath);
---
>       $form_state['values']['url']=file_create_url($file->filepath);

Sincerely,
Alex