facet theme function clean-up [#463900]

Comment	File	Size	Author
#5	facet_cleanup-463900-5.patch	12.69 KB	pwolanin
#4	facet_cleanup-463900-4.patch	11.05 KB	JacobSingh
#3	facet-cleanup-463900-3.patch	9.85 KB	pwolanin
#1	facet-cleanup-463900-1.patch	9.85 KB	pwolanin

Status	File	Size
new	facet-cleanup-463900-1.patch	9.85 KB

Comment #2

David Lesieur commented 22 May 2009 at 16:36

Patch seems to work well.
By moving the $count argument of theme_apachesolr_facet_item() after $path and $options, it would be more consistent with theme_apachesolr_unclick_link().

Log in or register to post comments

Comment #3

pwolanin commented 18 June 2009 at 01:58

Status	File	Size
new	facet-cleanup-463900-3.patch	9.85 KB

revised patch per suggestion.

Log in or register to post comments

Comment #4

JacobSingh commented 18 June 2009 at 07:50

Status	File	Size
new	facet_cleanup-463900-4.patch	11.05 KB

While reviewing the patch, I uncovered this bug: http://drupal.org/node/495012

Which is not related to the patch itself.

The patch itself looks okay, I don't think it will be totally intuitive for most themer. For instance ,we have apachesolr_facet_item and apachesolr_unclick_link. Should it be apachesolr_add_facet_link and apachesolr_remove_facet_link?

Anyway, here is another one with a little bit of docs in apachesolr.module as a starting point.