Posted by pwolanin on May 15, 2009 at 6:15pm
| Project: | Apache Solr Search Integration |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The facet and unclick link code is a bit ugly - I think we can separate things a bit to make the code easier to understand
Comments
#1
#2
Patch seems to work well.
By moving the $count argument of theme_apachesolr_facet_item() after $path and $options, it would be more consistent with theme_apachesolr_unclick_link().
#3
revised patch per suggestion.
#4
While reviewing the patch, I uncovered this bug: http://drupal.org/node/495012
Which is not related to the patch itself.
The patch itself looks okay, I don't think it will be totally intuitive for most themer. For instance ,we have apachesolr_facet_item and apachesolr_unclick_link. Should it be apachesolr_add_facet_link and apachesolr_remove_facet_link?
Anyway, here is another one with a little bit of docs in apachesolr.module as a starting point.
#5
for consistency, changing apachesolr_facet_item to apachesolr_facet_link, but I think longer names are unwieldy.
Also, making the signature of apachesolr_sort_link match.
#6
I didn't test this last patch, but if that's all you changed I give it a thumbs up.
#7
committed to 6.x (note I added the change to the REAME manually - I mised it in the last patch)
#8
See #496650: Unclick links don't work in 6.x-1.x-dev 2009-Jun-19
#9
Automatically closed -- issue fixed for 2 weeks with no activity.