This is a minor, minor thing, but it seems like the settings menu item should have a description. E.g.:

  $items['admin/settings/feedapi'] = array(
    'title' => 'FeedAPI settings',
    'description' => "Basic settings for FeedAPI module.",
    'page callback' => 'drupal_get_form',
    'page arguments' => array('feedapi_admin_settings'),
    'access arguments' => array('administer feedapi'),
  );

Happy to offer a patch if you want one.

CommentFileSizeAuthor
#4 description-settings.patch473 bytescrookednumber

Comments

alex_b’s picture

Version: 6.x-1.6 » 6.x-1.x-dev

Glad to accept one :)

crookednumber’s picture

Absolutely.

The language OK?

Love the module, BTW. I'm getting a ton of use out of it.

alex_b’s picture

Language could be more specific. What about:

"Control allowed tags and allocate cron time for FeedAPI."

?

crookednumber’s picture

Status: Active » Patch (to be ported)
StatusFileSize
new473 bytes

Patch attached.

aron novak’s picture

Title: Description for settings menu item » Proper description for settings menu item
Category: bug » feature
Status: Patch (to be ported) » Postponed (maintainer needs more info)

Thank you for the patch, however that item has description already:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/fee...

Do we want to change the current text: "Configure advanced options for FeedAPI module." ?

crookednumber’s picture

Sorry. I totally missed that. I was looking at HEAD.

aron novak’s picture

Well, in fact FeedAPI misuses HEAD, so it's not your fault at all.

crookednumber’s picture

Thanks. I'm still getting my head around CVS tags and branches and I thought this was another 2 steps back in my education. Phew!

aron novak’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

I think this is settled now.