Yay, an Oracle driver! However, I do not see any blob handling so all the text field are constricted in length to 4096. Also, it would be great if you would report on the project page how far this driver goes -- does Drupal 7 install, how many tests pass.

Comments

aaaristo’s picture

Status: Active » Fixed

chx, the blob handling is all there...
It passes al the Database test cases and i have tried it with all core modules enabled.

aaaristo’s picture

Status: Fixed » Closed (works as designed)
chx’s picture

Status: Closed (works as designed) » Fixed

YAY there is, indeed, blob handling. Have you tried to run more than Database tests? LIke, all tests?

aaaristo’s picture

No actually i don't. I tried to run a couple of tests but i've seen some minor things i should fix. I think i'am going to test the whole suite in a couple of weeks, but i don't know if is the right time: i mean 7.x is -dev... so i'am worried about debuggin the 7.x code instead of the oracle driver code...

For example, it seems that the DatabaseConnection->lastInsertId($sequence_name) method always return the last inserted id of any db_prefix, for example on MySQL:

if you insert the BID of BLOCKS table with $db_prefix == DUMMY and then call lastInsertId it will return N.
if the you recall it without $db_prefix it will return N again, even if db_prefix is null or empty.

Is this a "wanted" way of work or a "side effect". In any of this two cases i have to reproduce the same functionality on the Oracle driver for compatibility, so...

WDYT? Is a good idea to run the whole suite now?

chx’s picture

Title: Blob handling? » Test suite
Status: Fixed » Active

Well the whole suite passes on MySQL (guaranteed by testing infra) and Josh Waihi told me a few days ago that postgresql is passing too. I do not get your problem with last insert id, the db prefix is not really supposed to change in between two function calls just like that...? Care to show some code? Moved the issue to what we are talking now, btw.

BTW: congrats on Oracle driver.

aaaristo’s picture

Assigned: Unassigned » aaaristo

Thanks chx,
now the lastinsertId problem is fixed it was my misunderstanding of some tricky things on sequence name generation.
So actually i'am going to test the whole suite.

aaaristo’s picture

Status: Active » Needs work
aaaristo’s picture

Status: Needs work » Fixed

it seams to pass al the suite... :)

(openid does not work either on mysql on my testbed so... )
and
File space used tests: 4 passes, 6 fails, and 0 exceptions
seems not to be related with the database driver so..
again it seems to work.

aaaristo’s picture

Status: Fixed » Closed (fixed)
aaaristo’s picture

Status: Closed (fixed) » Needs work

found the files problem...

aaaristo’s picture

Status: Needs work » Closed (fixed)

was a & -> BITAND translation problem fixed

aaaristo’s picture

The OpenID problem was dued to the lack of php-bcmath.i386 library.