We supply menu_name instead of :menu and similarly for mlid. Seemingly PDO gets away with it but our preg based replacement does not. The manual examples clearly show colon-placeholders.

CommentFileSizeAuthor
#3 sqlite_placeholders.patch1.27 KBchx
#2 sqlite_placeholders.patch1.14 KBchx
#1 sqlite_placeholders.patch893 byteschx
system_placeholders.patch824 byteschx

Comments

chx’s picture

chx commented
Title: Wrong placeholder names cause empty admin page » PDO allows optional colon and SQLite does not
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new sqlite_placeholders.patch893 bytes

I mark this ready because this only changes the SQLite driver to conform to the design decision http://marc.info/?l=php-internals&m=111234321827149&w=2 made here.

chx’s picture

chx commented
StatusFileSize
new sqlite_placeholders.patch1.14 KB

Sniff, the unset did not work obviously after changing the index. And PDO dies when it gets too many arguments.

chx’s picture

chx commented
StatusFileSize
new sqlite_placeholders.patch1.27 KB

Even more comments.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Huh. That's bizarre. I can see why that would be a nice convenience thing, but talk about confusing. But best to be consistent with what PDO does.

We need this patch because without it, the admin screen when using SQLite is completely blank. Presumably other queries relying on this behaviour are also failing, but this one is just the most obvious.

I shortened up the comments a bit on the unset() statement since they were a bit verbose, and committed this to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.