When I go to the login form (/user) and also then the user page I get having logged in I get an error message:

recoverable fatal error: Object of class stdClass could not be converted to string in /var/www/vhosts/atomkraftsfritt.org/httpdocs/sites/all/modules/spamicide/spamicide.module on line 441.

Changing that line from

$description = variable_get("spamicide_description_$lang_code", $default);

to

$description = variable_get("spamicide_description_" . $lang_code->language, $default);

fixes it

CommentFileSizeAuthor
#16 spamicide-1.3-patched.module.gz4.41 KBjleinenbach
#12 spamicide_error_fix.patch601 bytestsi

Comments

lipcpro’s picture

lipcpro commented
Assigned: Unassigned » lipcpro
Status: Patch (to be ported) » Fixed

Looks good to me. Being that there aren't any translations for this module, would you like to volunteer to add 1?

slarti’s picture

slarti commented

While the above *works* I realised after I'd posted and turn off the computer that it's kind of inefficient... We don't need a second copy of the whole $language variable. Chaning the line I altered back to it's original and replacing line 439 from

$lang_code = $language

to

$lang_code = $language->language;

has the same effect but it more efficient.

Re the translation: my Swedish may be up to it, but I'd better wait till my partner comes home to check it!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

slarti’s picture

slarti commented
Status: Closed (fixed) » Active

I'd fixed this locally but when i upgraded (which i thought would include the fix) the error came back. On investigation it was fixed in the 1.x-dev version, but for some reason not in the 1.2 version released later the same day? Apart from the version IDs and datestamp, the only difference between the two is the presence of this bug in 1.2. Is that deliberate? I notice that 1.2 is labelled as "Attempting to fix branch/tag issue" so I wonder if it got missed by accident? I don't think it's a big enough change to require a dev version!

ezra-g’s picture

ezra-g commented
Version: 6.x-1.0 » 6.x-1.2

Marked #487668: a lot of messages in log as a duplicate of this.

Anonymous’s picture

Anonymous (not verified) commented

I had the same issue, solved it with #2.
Thank slarti

jleinenbach’s picture

jleinenbach commented

Same as #6, solved it with #2.
Thank you slarti.

aldim’s picture

aldim commented

Thanks you slarti. It works. Solved it with #2.

ñull’s picture

ñull commented

bump

Please could somebody with that permission include this fix in a release version? Aparently since june nothing has been was done about it. Or may be this module is meanwhile without maintainer?

xanchez’s picture

xanchez commented

#2 is still working great.
Thanks slarti.

aschiwi’s picture

aschiwi commented

This works for me as well. Is somebody here capable of creating patches? That might make it easier for the maintainer to commit this.

tsi’s picture

tsi commented
StatusFileSize
new spamicide_error_fix.patch601 bytes

Well, here is a patch for the fix in #2 against head.

ñull’s picture

ñull commented
Status: Active » Reviewed & tested by the community

fix works. Please submit and bring out an upgrade.

nadam’s picture

nadam commented
Priority: Normal » Critical

Changed priority to critical since the bug causes the module to not work at all for many people.

It's just one line of code (see #2 above) so it could easily be included in the next release.

meustrus’s picture

meustrus commented

If I make this fix manually, can I trust that the next release version will not break the fix? Asked another way, can I be certain that this fix will be in the next release version?

jleinenbach’s picture

jleinenbach commented
Version: 6.x-1.2 » 6.x-1.3
StatusFileSize
new spamicide-1.3-patched.module.gz4.41 KB

Patched module file v1.3. Fixes issues #744560: Installation does not create required directory and CSS is saved in the wrong path, #722014: Spamicide seems to install and configure OK but doesn't prevent spam in any form!!!!, #465100: "recoverable fatal error" with fix.

danielma’s picture

danielma commented

It is impossible to make Spamicide work for example on comments, contact_mail_page, user login and so on. It is so heavy problem to get smamicide to every form which is on my web page ? Thanks a lot.
And meanwhile, How can I recognize that it is working ? I mean really working. Thanks Martin

frank ralf’s picture

frank ralf commented
Status: Reviewed & tested by the community » Closed (duplicate)

The above patch is included in the most recent release. Please see #722014: Spamicide seems to install and configure OK but doesn't prevent spam in any form!!!! for the most recent discussion on this module. Marking this as duplicate therefor.