Three suggestions to improve fluidgrid:

  1. Don't use images for class="border colborder". Blueprint does this with classes like span-border-24
  2. Include a style.css with all Drupal declarations. See the zen.css from the Zen theme
  3. Put the images directory in the css directory. Most themes does it this way

Comments

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Status: Active » Needs work

Quick response to your suggestions.

1. The way fluidgrid works is not fit for border, as border uses 1px and that doesn't play nice with percentages. So I'll keep that solution unless I find a better way. I find that the image used is very small and doesn't impact the loading so much, but I appreciate that an obvious Blueprint user mention this as I used borders at first, and then changed to image after browser testing.

2. I never liked that about Zen, and always delete everything and create my own. FluidGrid comes with enough css, and the last thing I want to do is add extra code that people will delete anyway. Also, it could lead to code duplication. I prefer to provide the stylesheet ready to be filed than filed with unnecessary code. I understand that some would prefer their work already half done, but I think that too much guessing leads to unnecessary code.

3. I wouldn't agree with this, as even the default drupal themes like Garland have the image folder within the theme root, and I think it's more coherent as images are not css files, and I wouldn't look into a folder called CSS to find images.

Sorry to only come up with a general 'no' to your comment, but I really appreciate your comments, and they made me think about details I actually overlooked, or not considered, and it was a good thing to think about the reason things are this way.
Again, you open a discussion that everyone can comment, and welcome to, so depending on the reaction, I could review the previous statements.

Thanks for taking some time to submit your ideas, it's very much appreciated :)

mdroste’s picture

mdroste commented

1. The way fluidgrid works is not fit for border, as border uses 1px and that doesn't play nice with percentages. So I'll keep that solution unless I find a better way. I find that the image used is very small and doesn't impact the loading so much, but I appreciate that an obvious Blueprint user mention this as I used borders at first, and then changed to image after browser testing.

It's not a matter of the image size. But if one want to change the color of the border, he has to change the image. Of course I unerstand the problem that a 1px border doesn't work good with percentages. And that's the big + of fluidgrid.

2. I never liked that about Zen, and always delete everything and create my own. FluidGrid comes with enough css, and the last thing I want to do is add extra code that people will delete anyway. Also, it could lead to code duplication. I prefer to provide the stylesheet ready to be filed than filed with unnecessary code. I understand that some would prefer their work already half done, but I think that too much guessing leads to unnecessary code.

I think there is no problem to give users a file like 'suggestions.css' or whatever. And the user can choose to use it or not. Just comment it out in the fluidgrid.info file.

3. I wouldn't agree with this, as even the default drupal themes like Garland have the image folder within the theme root, and I think it's more coherent as images are not css files, and I wouldn't look into a folder called CSS to find images.

Yes, Garland has a images directory in the themes root. But you use a 'css' subdirectory in your theme. That's not quite the same.
In Garland and most other themes one can reference images like this: background: url(images/...). This is not possible in your theme (one must use './images instead) and therefore uncommonly for most themers and developers.

Thanks for your quick response.

Anonymous’s picture

Anonymous (not verified) commented

After thinking more about it, I'd agree that the image folder in the css might actually make more sense, I'll update that for the next release.

About the suggestion.css, I'd agree that there is no problem adding one, but it's imho it's a step too far into guessing what users want to do with the theme. CSS is a very particular code language, that can be dealt with in very different manners, and imposing a way isn't something I want fluidgrid to do, so even if it's something that would be easy to remove every time, it's just a concept that I don't see fluidgrid fit for.

mdroste’s picture

mdroste commented
Status: Needs work » Closed (fixed)

After thinking more about it, I'd agree that the image folder in the css might actually make more sense, I'll update that for the next release.

Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Closed (fixed) » Needs work

not included yet, reopening

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Closed (fixed)

Update :

- no more borders in the theme, I leave it up to the themer.
- image folder ooved to the css folder.